RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 18:28:10 +00:00
Code Issues Activity Actions

Shell: Put background jobs into new process groups too

Browse source 
Fixes #4345.
This was done in 54b453b in the name of "fixing event loop processing in
subshells", but I do not see how a new PGID is supposed to affect the event
loop.
This seems to have been done by mistake, let's see if any tests fail
because of this.
This commit is contained in:
AnotherTest 2020-12-07 00:47:21 +03:30 • committed by Andreas Kling
parent 59b46a1f51
commit cd8268e6fb
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Shell/Shell.cpp
View file

@ -816,7 +816,7 @@ RefPtr<Job> Shell::run_command(const AST::Command& command)
}
pid_t pgid = is_first ? child : (command.pipeline ? command.pipeline->pgid : child);
if ((!m_is_subshell && command.should_wait) || command.pipeline) {
if (!m_is_subshell || command.pipeline) {
if (setpgid(child, pgid) < 0 && m_is_interactive)
perror("setpgid");