RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 18:57:35 +00:00
Code Issues Activity Actions

LibJS: Use IntrusiveList for keeping track of WeakContainers

Browse source
This commit is contained in:
Andreas Kling 2021-07-21 19:57:41 +02:00
parent 3fe1be20b7
commit cdc1315dc8
5 changed files with 49 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Userland/Libraries/LibJS/Runtime/WeakContainer.cpp Normal file
View file

@ -0,0 +1,31 @@
/*
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibJS/Heap/Heap.h>
#include <LibJS/Runtime/WeakContainer.h>
namespace JS {
WeakContainer::WeakContainer(Heap& heap)
: m_heap(heap)
{
m_heap.did_create_weak_container({}, *this);
}
WeakContainer::~WeakContainer()
{
deregister();
}
void WeakContainer::deregister()
{
if (!m_registered)
return;
m_heap.did_destroy_weak_container({}, *this);
m_registered = false;
}
}

26
Userland/Libraries/LibJS/Runtime/WeakContainer.h
View file

@ -6,36 +6,28 @@
#pragma once
#include <LibJS/Heap/Heap.h>
#include <AK/IntrusiveList.h>
namespace JS {
class WeakContainer {
public:
explicit WeakContainer(Heap& heap)
: m_heap(heap)
{
m_heap.did_create_weak_container({}, *this);
}
virtual ~WeakContainer()
{
deregister();
}
explicit WeakContainer(Heap&);
virtual ~WeakContainer();
virtual void remove_swept_cells(Badge<Heap>, Vector<Cell*>&) = 0;
protected:
void deregister()
{
if (!m_registered)
return;
m_heap.did_destroy_weak_container({}, *this);
m_registered = false;
}
void deregister();
private:
bool m_registered { true };
Heap& m_heap;
IntrusiveListNode<WeakContainer> m_list_node;
public:
using List = IntrusiveList<WeakContainer, RawPtr<WeakContainer>, &WeakContainer::m_list_node>;
};
}