RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-29 11:45:11 +00:00
Code Issues Activity Actions

AK: Implement StringView::to_number<T> from String::to_number<T>

Browse source 
Do exactly what String does, then use StringView's implementation as
String's new one. This should allow us to call to_number on a
StringView.
This commit is contained in:
Shannon Booth 2023-12-23 11:35:03 +13:00 • committed by Andreas Kling
parent b63eb4a4dd
commit cdf84a3e36
2 changed files with 14 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
AK/String.h
View file

@ -181,14 +181,7 @@ public:
template<Arithmetic T> template<Arithmetic T>
Optional<T> to_number(TrimWhitespace trim_whitespace = TrimWhitespace::Yes) const Optional<T> to_number(TrimWhitespace trim_whitespace = TrimWhitespace::Yes) const
{ {
#ifndef KERNEL return bytes_as_string_view().to_number<T>(trim_whitespace);
if constexpr (IsFloatingPoint<T>)
return StringUtils::convert_to_floating_point<T>(bytes_as_string_view(), trim_whitespace);
#endif
if constexpr (IsSigned<T>)
return StringUtils::convert_to_int<T>(bytes_as_string_view(), trim_whitespace);
else
return StringUtils::convert_to_uint<T>(bytes_as_string_view(), trim_whitespace);
} }
static ErrorOr<String> vformatted(StringView fmtstr, TypeErasedFormatParams&); static ErrorOr<String> vformatted(StringView fmtstr, TypeErasedFormatParams&);

13
AK/StringView.h
View file

@ -353,6 +353,19 @@ public:
}()); }());
} }
template<Arithmetic T>
Optional<T> to_number(TrimWhitespace trim_whitespace = TrimWhitespace::Yes) const
{
#ifndef KERNEL
if constexpr (IsFloatingPoint<T>)
return StringUtils::convert_to_floating_point<T>(*this, trim_whitespace);
#endif
if constexpr (IsSigned<T>)
return StringUtils::convert_to_int<T>(*this, trim_whitespace);
else
return StringUtils::convert_to_uint<T>(*this, trim_whitespace);
}
private: private:
friend class ByteString; friend class ByteString;
char const* m_characters { nullptr }; char const* m_characters { nullptr };