RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00
Code Issues Activity Actions

LibWeb: Replace Length::set_calculated_style() with ::make_calculated()

Browse source 
There's no need to modify the Length's calculated-value after creating
it, so let's make it immutable. :^)
This commit is contained in:
Sam Atkins 2022-01-25 12:11:23 +00:00 • committed by Andreas Kling
parent db04b5687d
commit ce0a516e59
4 changed files with 12 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/CSS/Length.cpp
View file

@ -40,6 +40,13 @@ Length Length::make_px(float value)
return Length(value, Type::Px);
}
Length Length::make_calculated(NonnullRefPtr<CalculatedStyleValue> calculated_style_value)
{
Length length { 0, Type::Calculated };
length.m_calculated_style = move(calculated_style_value);
return length;
}
Length Length::percentage_of(Percentage const& percentage) const
{
if (is_undefined_or_auto()) {
@ -71,11 +78,6 @@ Length Length::resolved_or_zero(Layout::Node const& layout_node) const
return resolved(make_px(0), layout_node);
}
void Length::set_calculated_style(CalculatedStyleValue* value)
{
m_calculated_style = value;
}
float Length::relative_length_to_px(Gfx::IntRect const& viewport_rect, Gfx::FontMetrics const& font_metrics, float root_font_size) const
{
switch (m_type) {