RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:17:45 +00:00
Code Issues Activity Actions

LookupServer: Propagate the errors from MulticastDNS::handle_packet()

Browse source 
This is a bit awkward, but I think it is better to make the caller
deal with possible errors.
This commit is contained in:
Alexander Narsudinov 2022-12-18 00:52:12 +03:00 • committed by Andreas Kling
parent e279a1723b
commit ce2ed7615a
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Services/LookupServer/MulticastDNS.cpp
View file

@ -44,26 +44,28 @@ MulticastDNS::MulticastDNS(Object* parent)
bind(IPv4Address(), 5353);
on_ready_to_receive = [this]() {
handle_packet();
if (auto result = handle_packet(); result.is_error()) {
dbgln("Failed to handle packet: {}", result.error());
}
};
// TODO: Announce on startup. We cannot just call announce() here,
// because it races with the network interfaces getting configured.
}
void MulticastDNS::handle_packet()
ErrorOr<void> MulticastDNS::handle_packet()
{
// TODO: propagate the error somehow
auto buffer = MUST(receive(1024));
auto buffer = TRY(receive(1024));
auto optional_packet = Packet::from_raw_packet(buffer.data(), buffer.size());
if (!optional_packet.has_value()) {
dbgln("Got an invalid mDNS packet");
return;
return {};
}
auto& packet = optional_packet.value();
if (packet.is_query())
handle_query(packet);
return {};
}
void MulticastDNS::handle_query(Packet const& packet)