mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 23:27:43 +00:00
Everywhere: Mark dependencies of most targets as PRIVATE
Otherwise, we end up propagating those dependencies into targets that link against that library, which creates unnecessary link-time dependencies. Also included are changes to readd now missing dependencies to tools that actually need them.
This commit is contained in:
parent
678db534ff
commit
ce2f1b845f
174 changed files with 386 additions and 384 deletions
|
@ -1,15 +1,15 @@
|
|||
serenity_testjs_test(test-js.cpp test-js)
|
||||
serenity_testjs_test(test-js.cpp test-js LIBS LibLocale)
|
||||
|
||||
install(TARGETS test-js RUNTIME DESTINATION bin OPTIONAL)
|
||||
link_with_locale_data(test-js)
|
||||
|
||||
serenity_test(test-invalid-unicode-js.cpp LibJS LIBS LibJS)
|
||||
serenity_test(test-invalid-unicode-js.cpp LibJS LIBS LibJS LibLocale)
|
||||
link_with_locale_data(test-invalid-unicode-js)
|
||||
|
||||
serenity_test(test-bytecode-js.cpp LibJS LIBS LibJS)
|
||||
serenity_test(test-bytecode-js.cpp LibJS LIBS LibJS LibLocale)
|
||||
link_with_locale_data(test-bytecode-js)
|
||||
|
||||
serenity_test(test-value-js.cpp LibJS LIBS LibJS)
|
||||
serenity_test(test-value-js.cpp LibJS LIBS LibJS LibLocale)
|
||||
link_with_locale_data(test-value-js)
|
||||
|
||||
serenity_component(
|
||||
|
@ -17,7 +17,7 @@ serenity_component(
|
|||
TARGETS test262-runner
|
||||
)
|
||||
add_executable(test262-runner test262-runner.cpp)
|
||||
target_link_libraries(test262-runner LibJS LibCore)
|
||||
target_link_libraries(test262-runner PRIVATE LibJS LibCore LibLocale)
|
||||
serenity_set_implicit_links(test262-runner)
|
||||
link_with_locale_data(test262-runner)
|
||||
install(TARGETS test262-runner RUNTIME DESTINATION bin OPTIONAL)
|
||||
|
@ -27,6 +27,6 @@ serenity_component(
|
|||
TARGETS test-test262
|
||||
)
|
||||
add_executable(test-test262 test-test262.cpp)
|
||||
target_link_libraries(test-test262 LibMain LibCore)
|
||||
target_link_libraries(test-test262 PRIVATE LibMain LibCore)
|
||||
serenity_set_implicit_links(test-test262)
|
||||
install(TARGETS test-test262 RUNTIME DESTINATION bin OPTIONAL)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue