Everywhere: Mark dependencies of most targets as PRIVATE

Otherwise, we end up propagating those dependencies into targets that link against that library, which creates unnecessary link-time dependencies. Also included are changes to readd now missing dependencies to tools that actually need them.
2025-08-06 21:57:47 +00:00 · 2022-10-21 21:43:56 +02:00 · 2022-10-21 21:43:56 +02:00 · ce2f1b845f
commit ce2f1b845f
parent 678db534ff
174 changed files with 386 additions and 384 deletions
--- a/Userland/Applications/3DFileViewer/CMakeLists.txt
+++ b/Userland/Applications/3DFileViewer/CMakeLists.txt
@ -12,4 +12,4 @@ set(SOURCES
 )

 serenity_app(3DFileViewer ICON app-3d-file-viewer)
-target_link_libraries(3DFileViewer LibGUI LibGL LibFileSystemAccessClient LibMain)
+target_link_libraries(3DFileViewer PRIVATE LibCore LibGfx LibGUI LibGL LibFileSystemAccessClient LibMain)
--- a/Userland/Applications/About/CMakeLists.txt
+++ b/Userland/Applications/About/CMakeLists.txt
@ -15,4 +15,4 @@ execute_process(COMMAND "git diff-index --quiet HEAD -- && echo tracked || echo
 add_definitions(-DGIT_COMMIT="${GIT_COMMIT}" -DGIT_BRANCH="${GIT_BRANCH}" -DGIT_CHANGES="${GIT_CHANGES}")

 serenity_bin(About)
-target_link_libraries(About LibGUI LibMain)
+target_link_libraries(About PRIVATE LibCore LibGfx LibGUI LibMain)
--- a/Userland/Applications/AnalogClock/CMakeLists.txt
+++ b/Userland/Applications/AnalogClock/CMakeLists.txt
@ -10,4 +10,4 @@ set(SOURCES
        )

 serenity_app(AnalogClock ICON app-analog-clock)
-target_link_libraries(AnalogClock LibGUI LibMain)
+target_link_libraries(AnalogClock PRIVATE LibCore LibGfx LibGUI LibMain)
--- a/Userland/Applications/Assistant/CMakeLists.txt
+++ b/Userland/Applications/Assistant/CMakeLists.txt
@ -10,4 +10,4 @@ set(SOURCES
    )

 serenity_app(Assistant ICON app-run)
-target_link_libraries(Assistant LibCore LibDesktop LibGUI LibJS LibMain LibThreading)
+target_link_libraries(Assistant PRIVATE LibCore LibDesktop LibGfx LibGUI LibJS LibMain LibThreading)
--- a/Userland/Applications/Browser/CMakeLists.txt
+++ b/Userland/Applications/Browser/CMakeLists.txt
@ -42,5 +42,5 @@ set(GENERATED_SOURCES
 )

 serenity_app(Browser ICON app-browser)
-target_link_libraries(Browser LibWebView LibWeb LibProtocol LibGUI LibDesktop LibConfig LibMain)
+target_link_libraries(Browser PRIVATE LibCore LibWebView LibWeb LibProtocol LibGUI LibDesktop LibConfig LibGfx LibIPC LibJS LibLocale LibMain LibSyntax)
 link_with_locale_data(Browser)
--- a/Userland/Applications/BrowserSettings/CMakeLists.txt
+++ b/Userland/Applications/BrowserSettings/CMakeLists.txt
@ -19,4 +19,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(BrowserSettings ICON app-browser)
-target_link_libraries(BrowserSettings LibGUI LibConfig LibMain)
+target_link_libraries(BrowserSettings PRIVATE LibCore LibGfx LibGUI LibConfig LibMain)
--- a/Userland/Applications/Calculator/CMakeLists.txt
+++ b/Userland/Applications/Calculator/CMakeLists.txt
@ -18,4 +18,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(Calculator ICON app-calculator)
-target_link_libraries(Calculator LibGUI LibMain)
+target_link_libraries(Calculator PRIVATE LibCore LibCrypto LibGfx LibGUI LibMain)
--- a/Userland/Applications/Calendar/CMakeLists.txt
+++ b/Userland/Applications/Calendar/CMakeLists.txt
@ -15,4 +15,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(Calendar ICON app-calendar)
-target_link_libraries(Calendar LibGUI LibMain)
+target_link_libraries(Calendar PRIVATE LibConfig LibCore LibGfx LibGUI LibMain)
--- a/Userland/Applications/CalendarSettings/CMakeLists.txt
+++ b/Userland/Applications/CalendarSettings/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(CalendarSettings ICON app-calendar)
-target_link_libraries(CalendarSettings LibConfig LibGUI LibMain)
+target_link_libraries(CalendarSettings PRIVATE LibConfig LibCore LibGfx LibGUI LibMain)
--- a/Userland/Applications/CharacterMap/CMakeLists.txt
+++ b/Userland/Applications/CharacterMap/CMakeLists.txt
@ -19,4 +19,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(CharacterMap ICON app-character-map)
-target_link_libraries(CharacterMap LibDesktop LibGUI LibMain LibUnicode)
+target_link_libraries(CharacterMap PRIVATE LibConfig LibCore LibDesktop LibGfx LibGUI LibMain LibUnicode)
--- a/Userland/Applications/ClockSettings/CMakeLists.txt
+++ b/Userland/Applications/ClockSettings/CMakeLists.txt
@ -19,5 +19,5 @@ set(GENERATED_SOURCES
 )

 serenity_app(ClockSettings ICON app-analog-clock) # FIXME: Create a ClockSettings icon.
-target_link_libraries(ClockSettings LibGUI LibMain LibLocale)
+target_link_libraries(ClockSettings PRIVATE LibConfig LibCore LibGfx LibGUI LibMain LibLocale)
 link_with_locale_data(ClockSettings)
--- a/Userland/Applications/CrashReporter/CMakeLists.txt
+++ b/Userland/Applications/CrashReporter/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(CrashReporter ICON app-crash-reporter)
-target_link_libraries(CrashReporter LibCore LibCoredump LibDesktop LibFileSystemAccessClient LibGUI LibMain)
+target_link_libraries(CrashReporter PRIVATE LibCore LibCoredump LibDebug LibDesktop LibFileSystemAccessClient LibGfx LibGUI LibMain LibThreading)
--- a/Userland/Applications/Debugger/CMakeLists.txt
+++ b/Userland/Applications/Debugger/CMakeLists.txt
@ -8,4 +8,4 @@ set(SOURCES
 )

 serenity_bin(Debugger)
-target_link_libraries(Debugger LibCore LibDebug LibLine LibMain LibX86)
+target_link_libraries(Debugger PRIVATE LibCore LibDebug LibLine LibMain LibX86)
--- a/Userland/Applications/DisplaySettings/CMakeLists.txt
+++ b/Userland/Applications/DisplaySettings/CMakeLists.txt
@ -33,4 +33,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(DisplaySettings ICON app-display-settings)
-target_link_libraries(DisplaySettings LibDesktop LibGUI LibConfig LibMain LibEDID)
+target_link_libraries(DisplaySettings PRIVATE LibCore LibDesktop LibGfx LibGUI LibConfig LibIPC LibMain LibEDID LibThreading)
--- a/Userland/Applications/Escalator/CMakeLists.txt
+++ b/Userland/Applications/Escalator/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(Escalator ICON app-escalator)
-target_link_libraries(Escalator LibCore LibDesktop LibGUI LibMain)
+target_link_libraries(Escalator PRIVATE LibCore LibDesktop LibGfx LibGUI LibMain)
--- a/Userland/Applications/FileManager/CMakeLists.txt
+++ b/Userland/Applications/FileManager/CMakeLists.txt
@ -25,4 +25,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(FileManager ICON app-file-manager)
-target_link_libraries(FileManager LibGUI LibDesktop LibConfig LibMain)
+target_link_libraries(FileManager PRIVATE LibCore LibGfx LibGUI LibDesktop LibConfig LibMain)
--- a/Userland/Applications/FontEditor/CMakeLists.txt
+++ b/Userland/Applications/FontEditor/CMakeLists.txt
@ -25,4 +25,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(FontEditor ICON app-font-editor)
-target_link_libraries(FontEditor LibGUI LibDesktop LibGfx LibMain LibUnicode)
+target_link_libraries(FontEditor PRIVATE LibConfig LibCore LibGUI LibDesktop LibGfx LibMain LibUnicode)
--- a/Userland/Applications/GamesSettings/CMakeLists.txt
+++ b/Userland/Applications/GamesSettings/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(GamesSettings ICON games)
-target_link_libraries(GamesSettings LibGUI LibMain LibCards)
+target_link_libraries(GamesSettings PRIVATE LibConfig LibCore LibGfx LibGUI LibMain LibCards)
--- a/Userland/Applications/Help/CMakeLists.txt
+++ b/Userland/Applications/Help/CMakeLists.txt
@ -21,4 +21,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(Help ICON app-help)
-target_link_libraries(Help LibWebView LibWeb LibMarkdown LibGUI LibDesktop LibMain)
+target_link_libraries(Help PRIVATE LibCore LibWebView LibWeb LibMarkdown LibGfx LibGUI LibDesktop LibMain)
--- a/Userland/Applications/HexEditor/CMakeLists.txt
+++ b/Userland/Applications/HexEditor/CMakeLists.txt
@ -24,4 +24,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(HexEditor ICON app-hex-editor)
-target_link_libraries(HexEditor LibGUI LibConfig LibDesktop LibFileSystemAccessClient LibMain)
+target_link_libraries(HexEditor PRIVATE LibCore LibGfx LibGUI LibConfig LibDesktop LibFileSystemAccessClient LibMain)
--- a/Userland/Applications/ImageViewer/CMakeLists.txt
+++ b/Userland/Applications/ImageViewer/CMakeLists.txt
@ -11,4 +11,4 @@ set(SOURCES
 )

 serenity_app(ImageViewer ICON filetype-image)
-target_link_libraries(ImageViewer LibDesktop LibGUI LibGfx LibImageDecoderClient LibMain)
+target_link_libraries(ImageViewer PRIVATE LibCore LibDesktop LibGUI LibGfx LibImageDecoderClient LibMain)
--- a/Userland/Applications/KeyboardMapper/CMakeLists.txt
+++ b/Userland/Applications/KeyboardMapper/CMakeLists.txt
@ -11,4 +11,4 @@ set(SOURCES
 )

 serenity_app(KeyboardMapper ICON app-keyboard-mapper)
-target_link_libraries(KeyboardMapper LibGUI LibKeyboard LibMain)
+target_link_libraries(KeyboardMapper PRIVATE LibCore LibGfx LibGUI LibKeyboard LibMain)
--- a/Userland/Applications/KeyboardSettings/CMakeLists.txt
+++ b/Userland/Applications/KeyboardSettings/CMakeLists.txt
@ -18,4 +18,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(KeyboardSettings ICON app-keyboard-settings)
-target_link_libraries(KeyboardSettings LibGUI LibKeyboard LibConfig LibMain)
+target_link_libraries(KeyboardSettings PRIVATE LibCore LibGfx LibGUI LibKeyboard LibConfig LibMain)
--- a/Userland/Applications/Magnifier/CMakeLists.txt
+++ b/Userland/Applications/Magnifier/CMakeLists.txt
@ -10,4 +10,4 @@ set(SOURCES
 )

 serenity_app(Magnifier ICON app-magnifier)
-target_link_libraries(Magnifier LibGfx LibGUI LibMain LibFileSystemAccessClient)
+target_link_libraries(Magnifier PRIVATE LibCore LibGfx LibGUI LibIPC LibMain LibFileSystemAccessClient)
--- a/Userland/Applications/Mail/CMakeLists.txt
+++ b/Userland/Applications/Mail/CMakeLists.txt
@ -20,4 +20,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(Mail ICON app-mail)
-target_link_libraries(Mail LibConfig LibCore LibDesktop LibGfx LibGUI LibIMAP LibWebView LibWeb LibMain)
+target_link_libraries(Mail PRIVATE LibConfig LibCore LibDesktop LibGfx LibGUI LibIMAP LibWebView LibWeb LibMain)
--- a/Userland/Applications/MailSettings/CMakeLists.txt
+++ b/Userland/Applications/MailSettings/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(MailSettings ICON app-mail)
-target_link_libraries(MailSettings LibConfig LibGUI LibMain)
+target_link_libraries(MailSettings PRIVATE LibConfig LibCore LibGfx LibGUI LibMain)
--- a/Userland/Applications/MouseSettings/CMakeLists.txt
+++ b/Userland/Applications/MouseSettings/CMakeLists.txt
@ -24,4 +24,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(MouseSettings ICON app-mouse)
-target_link_libraries(MouseSettings LibGUI LibMain)
+target_link_libraries(MouseSettings PRIVATE LibCore LibGfx LibGUI LibIPC LibMain)
--- a/Userland/Applications/NetworkSettings/CMakeLists.txt
+++ b/Userland/Applications/NetworkSettings/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(NetworkSettings ICON network)
-target_link_libraries(NetworkSettings LibGUI LibMain)
+target_link_libraries(NetworkSettings PRIVATE LibCore LibGfx LibGUI LibMain)
--- a/Userland/Applications/PDFViewer/CMakeLists.txt
+++ b/Userland/Applications/PDFViewer/CMakeLists.txt
@ -13,4 +13,4 @@ set(SOURCES
    )

 serenity_app(PDFViewer ICON app-pdf-viewer)
-target_link_libraries(PDFViewer LibGUI LibPDF LibFileSystemAccessClient LibConfig LibMain)
+target_link_libraries(PDFViewer PRIVATE LibCore LibGfx LibGUI LibPDF LibFileSystemAccessClient LibConfig LibMain)
--- a/Userland/Applications/PartitionEditor/CMakeLists.txt
+++ b/Userland/Applications/PartitionEditor/CMakeLists.txt
@ -15,4 +15,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(PartitionEditor ICON app-partition-editor)
-target_link_libraries(PartitionEditor LibMain LibGUI LibPartition)
+target_link_libraries(PartitionEditor PRIVATE LibCore LibGfx LibMain LibGUI LibPartition)
--- a/Userland/Applications/Piano/CMakeLists.txt
+++ b/Userland/Applications/Piano/CMakeLists.txt
@ -21,4 +21,4 @@ set(SOURCES
 )

 serenity_app(Piano ICON app-piano)
-target_link_libraries(Piano LibAudio LibDSP LibGUI LibMain)
+target_link_libraries(Piano PRIVATE LibAudio LibCore LibDSP LibGfx LibGUI LibIPC LibMain)
--- a/Userland/Applications/PixelPaint/CMakeLists.txt
+++ b/Userland/Applications/PixelPaint/CMakeLists.txt
@ -83,4 +83,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(PixelPaint ICON app-pixel-paint)
-target_link_libraries(PixelPaint LibImageDecoderClient LibGUI LibGfx LibFileSystemAccessClient LibConfig LibMain)
+target_link_libraries(PixelPaint PRIVATE LibCore LibImageDecoderClient LibGUI LibGfx LibFileSystemAccessClient LibConfig LibMain LibThreading)
--- a/Userland/Applications/Run/CMakeLists.txt
+++ b/Userland/Applications/Run/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(Run ICON app-run)
-target_link_libraries(Run LibCore LibDesktop LibGUI LibMain)
+target_link_libraries(Run PRIVATE LibCore LibDesktop LibGfx LibGUI LibMain)
--- a/Userland/Applications/Settings/CMakeLists.txt
+++ b/Userland/Applications/Settings/CMakeLists.txt
@ -9,4 +9,4 @@ set(SOURCES
 )

 serenity_app(Settings ICON app-settings)
-target_link_libraries(Settings LibGUI LibDesktop LibMain)
+target_link_libraries(Settings PRIVATE LibCore LibGfx LibGUI LibDesktop LibMain)
--- a/Userland/Applications/SoundPlayer/CMakeLists.txt
+++ b/Userland/Applications/SoundPlayer/CMakeLists.txt
@ -19,4 +19,4 @@ set(SOURCES
 )

 serenity_app(SoundPlayer ICON app-sound-player)
-target_link_libraries(SoundPlayer LibAudio LibDSP LibGUI LibMain LibThreading)
+target_link_libraries(SoundPlayer PRIVATE LibAudio LibCore LibDSP LibGfx LibGUI LibIPC LibMain LibThreading)
--- a/Userland/Applications/SpaceAnalyzer/CMakeLists.txt
+++ b/Userland/Applications/SpaceAnalyzer/CMakeLists.txt
@ -15,4 +15,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(SpaceAnalyzer ICON app-space-analyzer)
-target_link_libraries(SpaceAnalyzer LibDesktop LibGfx LibGUI LibMain)
+target_link_libraries(SpaceAnalyzer PRIVATE LibCore LibDesktop LibGfx LibGUI LibIPC LibMain)
--- a/Userland/Applications/Spreadsheet/CMakeLists.txt
+++ b/Userland/Applications/Spreadsheet/CMakeLists.txt
@ -42,7 +42,7 @@ set(GENERATED_SOURCES
 )

 serenity_app(Spreadsheet ICON app-spreadsheet)
-target_link_libraries(Spreadsheet LibFileSystemAccessClient LibGUI LibJS LibMain LibWebView LibWeb)
+target_link_libraries(Spreadsheet PRIVATE LibCore LibFileSystemAccessClient LibGfx LibGUI LibJS LibMain LibMarkdown LibSyntax LibWebView LibWeb)

 serenity_test(Writers/Test/TestXSVWriter.cpp Spreadsheet)

--- a/Userland/Applications/SystemMonitor/CMakeLists.txt
+++ b/Userland/Applications/SystemMonitor/CMakeLists.txt
@ -26,4 +26,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(SystemMonitor ICON app-system-monitor)
-target_link_libraries(SystemMonitor LibGUI LibSymbolication LibMain)
+target_link_libraries(SystemMonitor PRIVATE LibConfig LibCore LibGfx LibGUI LibMain LibSymbolication LibThreading)
--- a/Userland/Applications/Terminal/CMakeLists.txt
+++ b/Userland/Applications/Terminal/CMakeLists.txt
@ -9,4 +9,4 @@ set(SOURCES
 )

 serenity_app(Terminal ICON app-terminal)
-target_link_libraries(Terminal LibGUI LibVT LibMain)
+target_link_libraries(Terminal PRIVATE LibConfig LibCore LibDesktop LibGfx LibGUI LibVT LibMain)
--- a/Userland/Applications/TerminalSettings/CMakeLists.txt
+++ b/Userland/Applications/TerminalSettings/CMakeLists.txt
@ -18,4 +18,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(TerminalSettings ICON app-terminal)
-target_link_libraries(TerminalSettings LibGUI LibConfig LibMain LibVT)
+target_link_libraries(TerminalSettings PRIVATE LibCore LibGfx LibGUI LibConfig LibMain LibVT)
--- a/Userland/Applications/TextEditor/CMakeLists.txt
+++ b/Userland/Applications/TextEditor/CMakeLists.txt
@ -18,4 +18,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(TextEditor ICON app-text-editor)
-target_link_libraries(TextEditor LibWebView LibWeb LibMarkdown LibGUI LibShell LibRegex LibDesktop LibCpp LibJS LibSQL LibFileSystemAccessClient LibConfig LibMain)
+target_link_libraries(TextEditor PRIVATE LibCore LibWebView LibWeb LibMarkdown LibGfx LibGUI LibShell LibRegex LibDesktop LibCpp LibJS LibSQL LibSyntax LibFileSystemAccessClient LibConfig LibMain)
--- a/Userland/Applications/ThemeEditor/CMakeLists.txt
+++ b/Userland/Applications/ThemeEditor/CMakeLists.txt
@ -28,4 +28,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(ThemeEditor ICON app-theme-editor)
-target_link_libraries(ThemeEditor LibGUI LibFileSystemAccessClient LibMain)
+target_link_libraries(ThemeEditor PRIVATE LibCore LibGfx LibGUI LibFileSystemAccessClient LibIPC LibMain)
--- a/Userland/Applications/VideoPlayer/CMakeLists.txt
+++ b/Userland/Applications/VideoPlayer/CMakeLists.txt
@ -11,4 +11,4 @@ set(SOURCES
 )

 serenity_bin(VideoPlayer)
-target_link_libraries(VideoPlayer LibVideo LibAudio LibGUI LibMain)
+target_link_libraries(VideoPlayer PRIVATE LibVideo LibAudio LibCore LibGfx LibGUI LibMain)
--- a/Userland/Applications/Welcome/CMakeLists.txt
+++ b/Userland/Applications/Welcome/CMakeLists.txt
@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )

 serenity_app(Welcome ICON app-welcome)
-target_link_libraries(Welcome LibGUI LibWebView LibWeb LibMain)
+target_link_libraries(Welcome PRIVATE LibConfig LibCore LibGfx LibGUI LibWebView LibWeb LibMain)