mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 03:57:44 +00:00
Everywhere: Mark dependencies of most targets as PRIVATE
Otherwise, we end up propagating those dependencies into targets that link against that library, which creates unnecessary link-time dependencies. Also included are changes to readd now missing dependencies to tools that actually need them.
This commit is contained in:
parent
678db534ff
commit
ce2f1b845f
174 changed files with 386 additions and 384 deletions
|
@ -58,5 +58,5 @@ set(GENERATED_SOURCES
|
|||
)
|
||||
|
||||
serenity_app(HackStudio ICON app-hack-studio)
|
||||
target_link_libraries(HackStudio LibWebView LibWeb LibMarkdown LibGUI LibCpp LibGfx LibCore LibVT LibDebug LibX86 LibDiff LibShell LibSymbolication LibRegex LibSQL LibCoredump LibMain)
|
||||
target_link_libraries(HackStudio PRIVATE LibWebView LibWeb LibMarkdown LibGUI LibCpp LibGfx LibCore LibVT LibDebug LibX86 LibDiff LibShell LibSymbolication LibSyntax LibRegex LibSQL LibConfig LibCore LibCoredump LibDesktop LibIPC LibJS LibMain LibThreading)
|
||||
add_dependencies(HackStudio CppLanguageServer)
|
||||
|
|
|
@ -9,7 +9,7 @@ set(GENERATED_SOURCES
|
|||
LanguageServerEndpoint.h)
|
||||
|
||||
serenity_lib(LibLanguageServer languageserver)
|
||||
target_link_libraries(LibLanguageServer LibCodeComprehension)
|
||||
target_link_libraries(LibLanguageServer PRIVATE LibCodeComprehension LibCore)
|
||||
|
||||
add_subdirectory(Cpp)
|
||||
add_subdirectory(Shell)
|
||||
|
|
|
@ -15,4 +15,4 @@ serenity_bin(CppLanguageServer)
|
|||
|
||||
# We link with LibGUI because we use GUI::TextDocument to update
|
||||
# the content of files according to the edit actions we receive over IPC.
|
||||
target_link_libraries(CppLanguageServer LibIPC LibCpp LibGUI LibLanguageServer LibCppComprehension LibMain)
|
||||
target_link_libraries(CppLanguageServer PRIVATE LibIPC LibCore LibCpp LibGUI LibLanguageServer LibCppComprehension LibMain LibRegex)
|
||||
|
|
|
@ -15,4 +15,4 @@ serenity_bin(ShellLanguageServer)
|
|||
|
||||
# We link with LibGUI because we use GUI::TextDocument to update
|
||||
# the content of files according to the edit actions we receive over IPC.
|
||||
target_link_libraries(ShellLanguageServer LibIPC LibShell LibGUI LibLanguageServer LibShellComprehension LibMain)
|
||||
target_link_libraries(ShellLanguageServer PRIVATE LibCore LibIPC LibShell LibGUI LibLanguageServer LibShellComprehension LibMain)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue