RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 10:07:35 +00:00
Code Issues Activity Actions

Everywhere: Mark dependencies of most targets as PRIVATE

Browse source 
Otherwise, we end up propagating those dependencies into targets that
link against that library, which creates unnecessary link-time
dependencies.

Also included are changes to readd now missing dependencies to tools
that actually need them.
This commit is contained in:
Tim Schumacher 2022-10-21 21:43:56 +02:00 • committed by Linus Groh
parent 678db534ff
commit ce2f1b845f
174 changed files with 386 additions and 384 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Games/2048/CMakeLists.txt
View file

@ -20,4 +20,4 @@ set(GENERATED_SOURCES
)
serenity_app(2048 ICON app-2048)
target_link_libraries(2048 LibConfig LibGUI LibMain LibDesktop)
target_link_libraries(2048 PRIVATE LibConfig LibCore LibGfx LibGUI LibMain LibDesktop)

2
Userland/Games/Chess/CMakeLists.txt
View file

@ -13,4 +13,4 @@ set(SOURCES
)
serenity_app(Chess ICON app-chess)
target_link_libraries(Chess LibChess LibConfig LibFileSystemAccessClient LibGUI LibCore LibMain LibDesktop)
target_link_libraries(Chess PRIVATE LibChess LibConfig LibFileSystemAccessClient LibGfx LibGUI LibCore LibMain LibDesktop)

2
Userland/Games/FlappyBug/CMakeLists.txt
View file

@ -10,4 +10,4 @@ set(SOURCES
)
serenity_app(FlappyBug ICON app-flappybug)
target_link_libraries(FlappyBug LibGUI LibConfig LibMain LibDesktop)
target_link_libraries(FlappyBug PRIVATE LibCore LibGfx LibGUI LibConfig LibMain LibDesktop)

2
Userland/Games/GameOfLife/CMakeLists.txt
View file

@ -18,4 +18,4 @@ set(GENERATED_SOURCES
)
serenity_app(GameOfLife ICON app-gameoflife)
target_link_libraries(GameOfLife LibGUI LibMain LibDesktop)
target_link_libraries(GameOfLife PRIVATE LibCore LibGfx LibGUI LibMain LibDesktop)

2
Userland/Games/Hearts/CMakeLists.txt
View file

@ -20,4 +20,4 @@ set(GENERATED_SOURCES
)
serenity_app(Hearts ICON app-hearts)
target_link_libraries(Hearts LibCards LibGUI LibGfx LibCore LibConfig LibMain LibDesktop)
target_link_libraries(Hearts PRIVATE LibCards LibGUI LibGfx LibCore LibConfig LibMain LibDesktop)

2
Userland/Games/MasterWord/CMakeLists.txt
View file

@ -10,4 +10,4 @@ set(SOURCES
)
serenity_app(MasterWord ICON app-masterword)
target_link_libraries(MasterWord LibGUI LibConfig LibMain LibDesktop)
target_link_libraries(MasterWord PRIVATE LibCore LibGfx LibGUI LibConfig LibMain LibDesktop)

2
Userland/Games/Minesweeper/CMakeLists.txt
View file

@ -19,4 +19,4 @@ set(GENERATED_SOURCES
)
serenity_app(Minesweeper ICON app-minesweeper)
target_link_libraries(Minesweeper LibGUI LibConfig LibMain LibDesktop)
target_link_libraries(Minesweeper PRIVATE LibCore LibGfx LibGUI LibConfig LibMain LibDesktop)

2
Userland/Games/Snake/CMakeLists.txt
View file

@ -10,4 +10,4 @@ set(SOURCES
)
serenity_app(Snake ICON app-snake)
target_link_libraries(Snake LibGUI LibConfig LibMain LibDesktop)
target_link_libraries(Snake PRIVATE LibCore LibGfx LibGUI LibConfig LibMain LibDesktop)

2
Userland/Games/Solitaire/CMakeLists.txt
View file

@ -16,4 +16,4 @@ set(GENERATED_SOURCES
)
serenity_app(Solitaire ICON app-solitaire)
target_link_libraries(Solitaire LibCards LibConfig LibGUI LibGfx LibCore LibMain)
target_link_libraries(Solitaire PRIVATE LibCards LibConfig LibGUI LibGfx LibCore LibMain)

2
Userland/Games/Spider/CMakeLists.txt
View file

@ -16,4 +16,4 @@ set(GENERATED_SOURCES
)
serenity_app(Spider ICON app-spider)
target_link_libraries(Spider LibCards LibGUI LibGfx LibCore LibConfig LibMain)
target_link_libraries(Spider PRIVATE LibCards LibGUI LibGfx LibCore LibConfig LibMain)