RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 02:07:35 +00:00
Code Issues Activity Actions

Everywhere: Mark dependencies of most targets as PRIVATE

Browse source 
Otherwise, we end up propagating those dependencies into targets that
link against that library, which creates unnecessary link-time
dependencies.

Also included are changes to readd now missing dependencies to tools
that actually need them.
This commit is contained in:
Tim Schumacher 2022-10-21 21:43:56 +02:00 • committed by Linus Groh
parent 678db534ff
commit ce2f1b845f
174 changed files with 386 additions and 384 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibLocale/CMakeLists.txt
View file

@ -10,7 +10,7 @@ if (DEFINED LOCALE_DATA_SOURCES)
serenity_generated_sources(LibLocaleData)
endif()
target_compile_options(LibLocaleData PRIVATE -g0 -Os -Wno-parentheses-equality)
target_link_libraries(LibLocaleData LibCore LibTimeZone)
target_link_libraries(LibLocaleData PRIVATE LibCore LibTimeZone)
unset(GENERATED_SOURCES)
endif()
@ -23,13 +23,13 @@ set(SOURCES
)
serenity_lib(LibLocale locale)
target_link_libraries(LibLocale LibCore LibUnicode)
target_link_libraries(LibLocale PRIVATE LibCore LibUnicode)
target_compile_definitions(LibLocale PRIVATE ENABLE_UNICODE_DATA=$<BOOL:${ENABLE_UNICODE_DATABASE_DOWNLOAD}>)
if (DEFINED LOCALE_DATA_SOURCES)
if (SERENITYOS)
add_dependencies(LibLocale LibLocaleData)
else()
target_link_libraries(LibLocale LibLocaleData)
target_link_libraries(LibLocale PRIVATE LibLocaleData)
endif()
endif()