Everywhere: Mark dependencies of most targets as PRIVATE

Otherwise, we end up propagating those dependencies into targets that
link against that library, which creates unnecessary link-time
dependencies.

Also included are changes to readd now missing dependencies to tools
that actually need them.

Userland/Services/AudioServer/CMakeLists.txt

@@ -19,4 +19,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(AudioServer)
-target_link_libraries(AudioServer LibCore LibThreading LibIPC LibMain)
+target_link_libraries(AudioServer PRIVATE LibCore LibThreading LibIPC LibMain)

Userland/Services/ChessEngine/CMakeLists.txt

@@ -10,4 +10,4 @@ set(SOURCES
 )
 
 serenity_bin(ChessEngine)
-target_link_libraries(ChessEngine LibChess LibCore LibMain)
+target_link_libraries(ChessEngine PRIVATE LibChess LibCore LibMain)

Userland/Services/Clipboard/CMakeLists.txt

@@ -19,4 +19,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(Clipboard)
-target_link_libraries(Clipboard LibCore LibIPC LibMain)
+target_link_libraries(Clipboard PRIVATE LibCore LibIPC LibMain)

Userland/Services/ConfigServer/CMakeLists.txt

@@ -18,4 +18,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(ConfigServer)
-target_link_libraries(ConfigServer LibIPC LibMain)
+target_link_libraries(ConfigServer PRIVATE LibCore LibIPC LibMain)

Userland/Services/CrashDaemon/CMakeLists.txt

@@ -9,4 +9,4 @@ set(SOURCES
 )
 
 serenity_bin(CrashDaemon)
-target_link_libraries(CrashDaemon LibCompress LibCore LibCoredump LibMain)
+target_link_libraries(CrashDaemon PRIVATE LibCompress LibCore LibCoredump LibMain)

Userland/Services/DHCPClient/CMakeLists.txt

@@ -11,4 +11,4 @@ set(SOURCES
 )
 
 serenity_bin(DHCPClient)
-target_link_libraries(DHCPClient LibCore LibMain)
+target_link_libraries(DHCPClient PRIVATE LibCore LibMain)

Userland/Services/EchoServer/CMakeLists.txt

@@ -9,4 +9,4 @@ set(SOURCES
 )
 
 serenity_bin(EchoServer)
-target_link_libraries(EchoServer LibCore LibMain)
+target_link_libraries(EchoServer PRIVATE LibCore LibMain)

Userland/Services/FileOperation/CMakeLists.txt

@@ -8,4 +8,4 @@ set(SOURCES
 )
 
 serenity_bin(FileOperation)
-target_link_libraries(FileOperation LibCore LibMain)
+target_link_libraries(FileOperation PRIVATE LibCore LibMain)

Userland/Services/FileSystemAccessServer/CMakeLists.txt

@@ -18,5 +18,5 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(FileSystemAccessServer)
-target_link_libraries(FileSystemAccessServer LibCore LibIPC LibGUI LibMain)
+target_link_libraries(FileSystemAccessServer PRIVATE LibCore LibIPC LibGfx LibGUI LibMain)
 add_dependencies(FileSystemAccessServer WindowServer)

Userland/Services/ImageDecoder/CMakeLists.txt

@@ -17,4 +17,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(ImageDecoder)
-target_link_libraries(ImageDecoder LibGfx LibIPC LibMain)
+target_link_libraries(ImageDecoder PRIVATE LibCore LibGfx LibIPC LibMain)

Userland/Services/InspectorServer/CMakeLists.txt

@@ -19,4 +19,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(InspectorServer)
-target_link_libraries(InspectorServer LibIPC LibMain)
+target_link_libraries(InspectorServer PRIVATE LibCore LibIPC LibMain)

Userland/Services/KeyboardPreferenceLoader/CMakeLists.txt

@@ -9,4 +9,4 @@ set(SOURCES
 )
 
 serenity_bin(KeyboardPreferenceLoader)
-target_link_libraries(KeyboardPreferenceLoader LibCore LibMain)
+target_link_libraries(KeyboardPreferenceLoader PRIVATE LibCore LibMain)

Userland/Services/LaunchServer/CMakeLists.txt

@@ -19,4 +19,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(LaunchServer)
-target_link_libraries(LaunchServer LibCore LibIPC LibDesktop LibMain)
+target_link_libraries(LaunchServer PRIVATE LibCore LibIPC LibDesktop LibMain)

Userland/Services/LoginServer/CMakeLists.txt

@@ -16,4 +16,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(LoginServer)
-target_link_libraries(LoginServer LibGUI LibMain)
+target_link_libraries(LoginServer PRIVATE LibCore LibGfx LibGUI LibMain)

Userland/Services/LookupServer/CMakeLists.txt

@@ -21,4 +21,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(LookupServer)
-target_link_libraries(LookupServer LibCore LibDNS LibIPC LibMain)
+target_link_libraries(LookupServer PRIVATE LibCore LibDNS LibIPC LibMain)

Userland/Services/NetworkServer/CMakeLists.txt

@@ -9,4 +9,4 @@ set(SOURCES
 )
 
 serenity_bin(NetworkServer)
-target_link_libraries(NetworkServer LibCore LibConfig LibMain)
+target_link_libraries(NetworkServer PRIVATE LibCore LibConfig LibMain)

Userland/Services/NotificationServer/CMakeLists.txt

@@ -19,4 +19,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(NotificationServer)
-target_link_libraries(NotificationServer LibGUI LibIPC LibMain)
+target_link_libraries(NotificationServer PRIVATE LibCore LibGfx LibGUI LibIPC LibMain)

Userland/Services/RequestServer/CMakeLists.txt

@@ -26,4 +26,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(RequestServer)
-target_link_libraries(RequestServer LibCore LibIPC LibGemini LibHTTP LibMain)
+target_link_libraries(RequestServer PRIVATE LibCore LibCrypto LibIPC LibGemini LibHTTP LibMain LibTLS)

Userland/Services/SQLServer/CMakeLists.txt

@@ -20,4 +20,4 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(SQLServer)
-target_link_libraries(SQLServer LibCore LibIPC LibSQL LibMain)
+target_link_libraries(SQLServer PRIVATE LibCore LibIPC LibSQL LibMain)

Userland/Services/SpiceAgent/CMakeLists.txt

@@ -10,5 +10,5 @@ set(SOURCES
 )
 
 serenity_bin(SpiceAgent)
-target_link_libraries(SpiceAgent LibGfx LibCore LibIPC LibMain)
+target_link_libraries(SpiceAgent PRIVATE LibGfx LibCore LibIPC LibMain)
 add_dependencies(SpiceAgent Clipboard)

Userland/Services/SystemServer/CMakeLists.txt

@@ -10,4 +10,4 @@ set(SOURCES
 )
 
 serenity_bin(SystemServer)
-target_link_libraries(SystemServer LibCore LibMain)
+target_link_libraries(SystemServer PRIVATE LibCore LibMain)

Userland/Services/Taskbar/CMakeLists.txt

@@ -15,5 +15,5 @@ set(SOURCES
 )
 
 serenity_bin(Taskbar)
-target_link_libraries(Taskbar LibGUI LibDesktop LibConfig LibMain)
+target_link_libraries(Taskbar PRIVATE LibCore LibGfx LibGUI LibDesktop LibConfig LibIPC LibMain)
 serenity_install_headers(Services/Taskbar)

Userland/Services/TelnetServer/CMakeLists.txt

@@ -10,4 +10,4 @@ set(SOURCES
 )
 
 serenity_bin(TelnetServer)
-target_link_libraries(TelnetServer LibCore LibMain)
+target_link_libraries(TelnetServer PRIVATE LibCore LibMain)

Userland/Services/WebContent/CMakeLists.txt

@@ -22,5 +22,5 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(WebContent)
-target_link_libraries(WebContent LibCore LibIPC LibGfx LibImageDecoderClient LibWebView LibWeb LibMain)
+target_link_libraries(WebContent PRIVATE LibCore LibIPC LibGfx LibImageDecoderClient LibJS LibWebView LibWeb LibLocale LibMain)
 link_with_locale_data(WebContent)

Userland/Services/WebDriver/CMakeLists.txt

@@ -18,4 +18,4 @@ set(GENERATED_SOURCES
     )
 
 serenity_bin(WebDriver)
-target_link_libraries(WebDriver LibCore LibHTTP LibMain LibIPC LibWeb)
+target_link_libraries(WebDriver PRIVATE LibCore LibHTTP LibMain LibIPC LibWeb)

Userland/Services/WebServer/CMakeLists.txt

@@ -10,4 +10,4 @@ set(SOURCES
 )
 
 serenity_bin(WebServer)
-target_link_libraries(WebServer LibCore LibHTTP LibMain)
+target_link_libraries(WebServer PRIVATE LibCore LibHTTP LibMain)

Userland/Services/WebSocket/CMakeLists.txt

@@ -21,4 +21,4 @@ set(GENERATED_SOURCES
 #    The server binary name is still WebSocket.
 serenity_bin(WebSocketServer)
 set_target_properties(WebSocketServer PROPERTIES OUTPUT_NAME WebSocket)
-target_link_libraries(WebSocketServer LibCore LibIPC LibWebSocket LibMain)
+target_link_libraries(WebSocketServer PRIVATE LibCore LibIPC LibWebSocket LibMain LibTLS)

Userland/Services/WindowServer/CMakeLists.txt

@@ -45,5 +45,5 @@ set(GENERATED_SOURCES
 )
 
 serenity_bin(WindowServer)
-target_link_libraries(WindowServer LibCore LibGfx LibThreading LibIPC LibMain)
+target_link_libraries(WindowServer PRIVATE LibCore LibGfx LibThreading LibIPC LibMain)
 serenity_install_headers(Services/WindowServer)