RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:27:45 +00:00
Code Issues Activity Actions

LibJS: Support MM/DD/YYYY HH:MM <timezone-offset> format for Date

Browse source 
Required by Discord to determine if it should show Christmas themed
loading tips on the loading screen.
Fixes #16473.
This commit is contained in:
Luke Wilde 2022-12-13 20:26:10 +00:00 • committed by Linus Groh
parent bb6a84cc85
commit ce39c907fd
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/DateConstructor.cpp
View file

@ -147,9 +147,10 @@ static double parse_simplified_iso8601(DeprecatedString const& iso_8601)
return time_clip(time_ms); return time_clip(time_ms);
} }
static constexpr AK::Array<StringView, 2> extra_formats = { static constexpr AK::Array<StringView, 3> extra_formats = {
"%a %b %e %T %z %Y"sv, "%a %b %e %T %z %Y"sv,
"%m/%e/%Y"sv "%m/%e/%Y"sv,
"%m/%e/%Y %R %z"sv,
}; };
static double parse_date_string(DeprecatedString const& date_string) static double parse_date_string(DeprecatedString const& date_string)
@ -161,6 +162,7 @@ static double parse_date_string(DeprecatedString const& date_string)
// Date.parse() is allowed to accept an arbitrary number of implementation-defined formats. // Date.parse() is allowed to accept an arbitrary number of implementation-defined formats.
// Parse formats of this type: "Wed Apr 17 23:08:53 +0000 2019" // Parse formats of this type: "Wed Apr 17 23:08:53 +0000 2019"
// And: "4/17/2019" // And: "4/17/2019"
// And: "12/05/2022 10:00 -0800"
// FIXME: Exactly what timezone and which additional formats we should support is unclear. // FIXME: Exactly what timezone and which additional formats we should support is unclear.
// Both Chrome and Firefox seem to support "4/17/2019 11:08 PM +0000" with most parts // Both Chrome and Firefox seem to support "4/17/2019 11:08 PM +0000" with most parts
// being optional, however this is not clearly documented anywhere. // being optional, however this is not clearly documented anywhere.

6
Userland/Libraries/LibJS/Tests/builtins/Date/Date.parse.js
View file

@ -78,3 +78,9 @@ test("extra date extension", () => {
expectStringToGiveDate("7/07/1977", 1977, 7, 7); expectStringToGiveDate("7/07/1977", 1977, 7, 7);
expectStringToGiveDate("2/27/3058", 3058, 2, 27); expectStringToGiveDate("2/27/3058", 3058, 2, 27);
}); });
test("mm/dd/yy hh:mm timezone-offset extension", () => {
// Examples from Discord's JavaScript for Christmas 2022.
expect(Date.parse("12/05/2022 10:00 -0800")).toBe(1670263200000);
expect(Date.parse("01/03/2023 10:00 -0800")).toBe(1672768800000);
});