RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:28:11 +00:00
Code Issues Activity Actions

LibJS + test-js: Get results from the global object directly

Browse source 
This is as the spec would require you to do it and necessary for changes
to come in the following commits.
This commit is contained in:
davidot 2021-09-18 16:31:50 +02:00 • committed by Linus Groh
parent 53cc7e8398
commit ce3f29a135
2 changed files with 15 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibJS/test-js.cpp
View file

@ -77,19 +77,19 @@ TESTJS_GLOBAL_FUNCTION(mark_as_garbage, markAsGarbage)
return {};
}
auto variable = outer_environment.value()->lexical_environment->get_from_environment(variable_name.string());
if (!variable.has_value()) {
vm.throw_exception<JS::ReferenceError>(global_object, JS::ErrorType::UnknownIdentifier, variable_name.string());
return {};
}
auto reference = vm.resolve_binding(variable_name.string(), outer_environment.value()->lexical_environment);
if (!variable->value.is_object()) {
auto value = reference.get_value(global_object);
if (vm.exception())
return {};
if (!value.is_object()) {
vm.throw_exception<JS::TypeError>(global_object, JS::ErrorType::NotAnObject, String::formatted("Variable with name {}", variable_name.string()));
return {};
}
vm.heap().uproot_cell(&variable->value.as_object());
outer_environment.value()->lexical_environment->delete_from_environment(variable_name.string());
vm.heap().uproot_cell(&value.as_object());
reference.delete_(global_object);
return JS::js_undefined();
}