1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:07:46 +00:00

LibJS: Use a custom property_name_to_value method instead of to_value

This commit is contained in:
davidot 2021-07-05 01:59:50 +02:00 committed by Linus Groh
parent 721238f41c
commit ce59e49e27
7 changed files with 104 additions and 6 deletions

View file

@ -27,6 +27,25 @@ describe("[[DefineProperty]] trap normal behavior", () => {
Object.defineProperty(p, "foo", { configurable: true, writable: true, value: 10 });
});
test("correct arguments passed to trap even for number", () => {
let o = {};
p = new Proxy(o, {
defineProperty(target, name, descriptor) {
expect(target).toBe(o);
expect(name).toBe("1");
expect(descriptor.configurable).toBeTrue();
expect(descriptor.enumerable).toBeUndefined();
expect(descriptor.writable).toBeTrue();
expect(descriptor.value).toBe(10);
expect(descriptor.get).toBeUndefined();
expect(descriptor.set).toBeUndefined();
return true;
},
});
Object.defineProperty(p, 1, { configurable: true, writable: true, value: 10 });
});
test("optionally ignoring the define call", () => {
let o = {};
let p = new Proxy(o, {

View file

@ -18,6 +18,19 @@ describe("[[Delete]] trap normal behavior", () => {
delete p.foo;
});
test("correct arguments passed to trap even for number", () => {
let o = {};
let p = new Proxy(o, {
deleteProperty(target, property) {
expect(target).toBe(o);
expect(property).toBe("1");
return true;
},
});
delete p[1];
});
test("conditional deletion", () => {
o = { foo: 1, bar: 2 };
p = new Proxy(o, {

View file

@ -18,6 +18,19 @@ describe("[[Get]] trap normal behavior", () => {
p.foo;
});
test("correct arguments passed to trap even for number", () => {
let o = {};
let p = new Proxy(o, {
get(target, property, receiver) {
expect(target).toBe(o);
expect(property).toBe("1");
expect(receiver).toBe(p);
},
});
p[1];
});
test("conditional return", () => {
let o = { foo: 1 };
let p = new Proxy(o, {

View file

@ -24,6 +24,18 @@ describe("[Call][GetOwnProperty]] trap normal behavior", () => {
Object.getOwnPropertyDescriptor(p, "foo");
});
test("correct arguments passed to trap even for number", () => {
let o = {};
let p = new Proxy(o, {
getOwnPropertyDescriptor(target, property) {
expect(target).toBe(o);
expect(property).toBe("1");
},
});
Object.getOwnPropertyDescriptor(p, 1);
});
test("conditional returned descriptor", () => {
let o = { foo: "bar" };
Object.defineProperty(o, "baz", {

View file

@ -18,6 +18,19 @@ describe("[[Has]] trap normal behavior", () => {
"foo" in p;
});
test("correct arguments passed to trap even for number", () => {
let o = {};
let p = new Proxy(o, {
has(target, prop) {
expect(target).toBe(o);
expect(prop).toBe("1");
return true;
},
});
1 in p;
});
test("conditional return", () => {
let o = {};
let p = new Proxy(o, {

View file

@ -20,6 +20,21 @@ describe("[[Set]] trap normal behavior", () => {
p.foo = 10;
});
test("correct arguments passed to trap even for number", () => {
let o = {};
let p = new Proxy(o, {
set(target, prop, value, receiver) {
expect(target).toBe(o);
expect(prop).toBe("1");
expect(value).toBe(10);
expect(receiver).toBe(p);
return true;
},
});
p[1] = 10;
});
test("conditional return value", () => {
let p = new Proxy(
{},