From ce5a308f24f18cf5b132823f70e2cc2ec6f2709c Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Tue, 20 Apr 2021 00:03:44 -0700 Subject: [PATCH] Kernel: Annotate more AsyncDeviceRequest API's with [[nodiscard]] --- Kernel/Devices/AsyncDeviceRequest.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Kernel/Devices/AsyncDeviceRequest.h b/Kernel/Devices/AsyncDeviceRequest.h index 9c49ecfad1..5358a77ad4 100644 --- a/Kernel/Devices/AsyncDeviceRequest.h +++ b/Kernel/Devices/AsyncDeviceRequest.h @@ -45,7 +45,7 @@ class AsyncDeviceRequest : public RefCounted { AK_MAKE_NONMOVABLE(AsyncDeviceRequest); public: - enum RequestResult { + enum [[nodiscard]] RequestResult { Pending = 0, Started, Success, @@ -145,14 +145,14 @@ private: void sub_request_finished(AsyncDeviceRequest&); void request_finished(); - bool in_target_context(const UserOrKernelBuffer& buffer) const + [[nodiscard]] bool in_target_context(const UserOrKernelBuffer& buffer) const { if (buffer.is_kernel_buffer()) return true; return m_process == Process::current(); } - static bool is_completed_result(RequestResult result) + [[nodiscard]] static bool is_completed_result(RequestResult result) { return result > Started; }