From ce775ea701686f5cb191e5771f2b1b49f6cac771 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Thu, 7 Sep 2023 17:43:10 +0100 Subject: [PATCH] LibWeb: Use a switch to handle TextTransform values This makes it more obvious that we're missing some of these. (And makes it easier to find this code when searching for a specific value.) --- Userland/Libraries/LibWeb/Layout/TextNode.cpp | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/Layout/TextNode.cpp b/Userland/Libraries/LibWeb/Layout/TextNode.cpp index 9a224c6fa2..ecf73a6d1f 100644 --- a/Userland/Libraries/LibWeb/Layout/TextNode.cpp +++ b/Userland/Libraries/LibWeb/Layout/TextNode.cpp @@ -34,11 +34,19 @@ static bool is_all_whitespace(StringView string) static ErrorOr apply_text_transform(DeprecatedString const& string, CSS::TextTransform text_transform) { - if (text_transform == CSS::TextTransform::Uppercase) + switch (text_transform) { + case CSS::TextTransform::Uppercase: return Unicode::to_unicode_uppercase_full(string); - if (text_transform == CSS::TextTransform::Lowercase) + case CSS::TextTransform::Lowercase: return Unicode::to_unicode_lowercase_full(string); - return string; + case CSS::TextTransform::None: + return string; + case CSS::TextTransform::Capitalize: + case CSS::TextTransform::FullSizeKana: + case CSS::TextTransform::FullWidth: + // FIXME: Implement these! + return string; + } } void TextNode::invalidate_text_for_rendering()