From ce7c8e215f7e730d4534d4cd32a7ccbb6179127d Mon Sep 17 00:00:00 2001
From: Tobias Christiansen <tobi@tobyase.de>
Date: Tue, 1 Jun 2021 15:50:17 +0200
Subject: [PATCH] LibWeb: Parse and resolve flex: shorthand

---
 Userland/Libraries/LibWeb/CSS/Properties.json |  7 +++
 .../Libraries/LibWeb/CSS/StyleResolver.cpp    | 48 +++++++++++++++++++
 2 files changed, 55 insertions(+)

diff --git a/Userland/Libraries/LibWeb/CSS/Properties.json b/Userland/Libraries/LibWeb/CSS/Properties.json
index 07d58d07e1..5cd131d997 100644
--- a/Userland/Libraries/LibWeb/CSS/Properties.json
+++ b/Userland/Libraries/LibWeb/CSS/Properties.json
@@ -203,6 +203,13 @@
     "inherited": false,
     "initial": "inline"
   },
+  "flex": {
+    "longhands": [
+      "flex-grow",
+      "flex-shrink",
+      "flex-basis"
+    ]
+  },
   "flex-basis": {
     "inherited": false,
     "initial": "content"
diff --git a/Userland/Libraries/LibWeb/CSS/StyleResolver.cpp b/Userland/Libraries/LibWeb/CSS/StyleResolver.cpp
index f23761c832..cf09c494a3 100644
--- a/Userland/Libraries/LibWeb/CSS/StyleResolver.cpp
+++ b/Userland/Libraries/LibWeb/CSS/StyleResolver.cpp
@@ -318,6 +318,54 @@ static void set_property_expanding_shorthands(StyleProperties& style, CSS::Prope
         return;
     }
 
+    if (property_id == CSS::PropertyID::Flex) {
+        if (value.is_length() || (value.is_identifier() && value.to_identifier() == CSS::ValueID::Content)) {
+            style.set_property(CSS::PropertyID::FlexBasis, value);
+            return;
+        }
+
+        if (!value.is_string())
+            return;
+
+        auto parts = split_on_whitespace(value.to_string());
+        if (parts.size() == 1) {
+            // FIXME: Parse float value here.
+            // FIXME: Maybe add NumericStyleValue or sth for that.
+            //        Also extend parse_css_value.
+            style.set_property(CSS::PropertyID::FlexGrow, ""sv);
+            return;
+        }
+
+        if (parts.size() == 2) {
+            // FIXME: Parse float value from parts[0] here.
+            style.set_property(CSS::PropertyID::FlexGrow, ""sv);
+
+            auto second_value = parse_css_value(context, parts[1]);
+            if (second_value->is_length() || (second_value->is_identifier() && second_value->to_identifier() == CSS::ValueID::Content)) {
+                style.set_property(CSS::PropertyID::FlexBasis, *second_value);
+            } else {
+                // FIXME: Parse float value from parts[1] here.
+                style.set_property(CSS::PropertyID::FlexShrink, ""sv);
+            }
+            return;
+        }
+
+        if (parts.size() == 3) {
+            // FIXME: Parse float value from parts[0] here.
+            style.set_property(CSS::PropertyID::FlexGrow, ""sv);
+            // FIXME: Parse float value from parts[1] here.
+            style.set_property(CSS::PropertyID::FlexShrink, ""sv);
+
+            auto third_value = parse_css_value(context, parts[2]);
+            if (third_value->is_length() || (third_value->is_identifier() && third_value->to_identifier() == CSS::ValueID::Content))
+                style.set_property(CSS::PropertyID::FlexBasis, *third_value);
+            return;
+        }
+
+        dbgln("Unsure what to do with CSS flex value '{}'", value.to_string());
+        return;
+    }
+
     if (property_id == CSS::PropertyID::BorderTop
         || property_id == CSS::PropertyID::BorderRight
         || property_id == CSS::PropertyID::BorderBottom