RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:18:12 +00:00
Code Issues Activity Actions

Kernel/PCI: Verify Access is not initialized before initializing it

Browse source 
There's no valid case where we should try to initialize the Access
singleton multiple times, therefore just assert if it ever happens.
This commit is contained in:
Liav A 2022-01-21 18:13:34 +02:00 • committed by Idan Horowitz
parent 78d1093dab
commit cecfd42916
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Bus/PCI/Access.cpp
View file

@ -88,9 +88,7 @@ UNMAP_AFTER_INIT bool Access::find_and_register_pci_host_bridges_from_acpi_mcfg_
UNMAP_AFTER_INIT bool Access::initialize_for_multiple_pci_domains(PhysicalAddress mcfg_table)
{
if (Access::is_initialized())
return false;
VERIFY(!Access::is_initialized());
auto* access = new Access();
if (!access->find_and_register_pci_host_bridges_from_acpi_mcfg_table(mcfg_table))
return false;
@ -101,9 +99,7 @@ UNMAP_AFTER_INIT bool Access::initialize_for_multiple_pci_domains(PhysicalAddres
UNMAP_AFTER_INIT bool Access::initialize_for_one_pci_domain()
{
if (Access::is_initialized()) {
return false;
}
VERIFY(!Access::is_initialized());
auto* access = new Access();
auto host_bridge = HostBridge::must_create_with_io_access();
access->add_host_controller(move(host_bridge));