LibWeb: Consolidate track sizing code for rows and columns in GFC

Browse source

Although the algorithm for sizing tracks (rows or columns) is defined
once for both dimensions in the specification
(https://www.w3.org/TR/css-grid-2/#algo-track-sizing), we have
implemented it twice separately for sizing rows and columns.

In addition to code duplication, another issue is that these
implementations of the same algorithm have already diverged in some
places, and this divergence is likely to become even worse as our
implementation evolves.

This change unifies code for both dimension into one method that runs
track sizing.

While this change brings a bit of collateral damange (border.html and
minmax.html got changes in layout snaphots) it ultimately brings more
benefits because now we can evolve layout for both rows and colums
without duplicating the code :)

...

This commit is contained in:

Aliaksandr Kalenik 2023-05-06 04:22:35 +03:00 • committed by Andreas Kling

parent 4c17f22735

commit ced862e16f

4 changed files with 252 additions and 691 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

755

Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp

View file

File diff suppressed because it is too large Load diff