RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:22:45 +00:00
Code Issues Activity Actions

LibGUI: Reset GlyphMapWidget only if clicking a new active glyph

Browse source 
Fixes an edge case in which mousing down on the active glyph within
a larger selection would reset the selection but fail to update the
glyph map. Now we can grow or shrink the selection by dragging the
active glyph even after an initial selection is made.
This commit is contained in:
thankyouverycool 2022-03-18 20:09:55 -04:00 • committed by Andreas Kling
parent 4f7b37de9c
commit cf13cf7225
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/GlyphMapWidget.cpp
View file

@ -167,12 +167,8 @@ void GlyphMapWidget::mousedown_event(MouseEvent& event)
auto glyph = maybe_glyph.value();
if (event.shift())
m_selection.extend_to(glyph);
else {
m_selection.set_size(1);
m_selection.set_start(glyph);
}
m_in_drag_select = true;
set_active_glyph(glyph, ShouldResetSelection::No);
set_active_glyph(glyph, event.shift() ? ShouldResetSelection::No : ShouldResetSelection::Yes);
}
}