1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00

Piano: Rename KnobsWidget to TrackControlsWidget

This more generic name will better reflect the purpose of the widget in
the future, as this commit begins the long process of enhancing the
widget into a container for all controls of Piano's currently selected
track.
This commit is contained in:
kleines Filmröllchen 2023-02-09 13:22:40 +01:00 committed by Andrew Kaster
parent 0190be9788
commit cf6676beb2
5 changed files with 12 additions and 12 deletions

View file

@ -11,12 +11,12 @@ set(SOURCES
AudioPlayerLoop.cpp AudioPlayerLoop.cpp
ExportProgressWindow.cpp ExportProgressWindow.cpp
KeysWidget.cpp KeysWidget.cpp
KnobsWidget.cpp
main.cpp main.cpp
MainWidget.cpp MainWidget.cpp
PlayerWidget.cpp PlayerWidget.cpp
RollWidget.cpp RollWidget.cpp
SamplerWidget.cpp SamplerWidget.cpp
TrackControlsWidget.cpp
TrackManager.cpp TrackManager.cpp
WaveWidget.cpp WaveWidget.cpp
ProcessorParameterWidget/ParameterWidget.cpp ProcessorParameterWidget/ParameterWidget.cpp

View file

@ -8,10 +8,10 @@
#include "MainWidget.h" #include "MainWidget.h"
#include "KeysWidget.h" #include "KeysWidget.h"
#include "KnobsWidget.h"
#include "PlayerWidget.h" #include "PlayerWidget.h"
#include "RollWidget.h" #include "RollWidget.h"
#include "SamplerWidget.h" #include "SamplerWidget.h"
#include "TrackControlsWidget.h"
#include "TrackManager.h" #include "TrackManager.h"
#include "WaveWidget.h" #include "WaveWidget.h"
#include <LibGUI/Action.h> #include <LibGUI/Action.h>
@ -55,7 +55,7 @@ ErrorOr<void> MainWidget::initialize()
m_keys_widget = TRY(m_keys_and_knobs_container->try_add<KeysWidget>(m_track_manager.keyboard())); m_keys_widget = TRY(m_keys_and_knobs_container->try_add<KeysWidget>(m_track_manager.keyboard()));
m_knobs_widget = TRY(m_keys_and_knobs_container->try_add<KnobsWidget>(m_track_manager, *this)); m_knobs_widget = TRY(m_keys_and_knobs_container->try_add<TrackControlsWidget>(m_track_manager, *this));
m_roll_widget->set_keys_widget(m_keys_widget); m_roll_widget->set_keys_widget(m_keys_widget);

View file

@ -19,7 +19,7 @@ class WaveWidget;
class RollWidget; class RollWidget;
class SamplerWidget; class SamplerWidget;
class KeysWidget; class KeysWidget;
class KnobsWidget; class TrackControlsWidget;
class PlayerWidget; class PlayerWidget;
class MainWidget final : public GUI::Widget { class MainWidget final : public GUI::Widget {
@ -57,7 +57,7 @@ private:
RefPtr<GUI::TabWidget> m_tab_widget; RefPtr<GUI::TabWidget> m_tab_widget;
RefPtr<GUI::Widget> m_keys_and_knobs_container; RefPtr<GUI::Widget> m_keys_and_knobs_container;
RefPtr<KeysWidget> m_keys_widget; RefPtr<KeysWidget> m_keys_widget;
RefPtr<KnobsWidget> m_knobs_widget; RefPtr<TrackControlsWidget> m_knobs_widget;
RefPtr<PlayerWidget> m_player_widget; RefPtr<PlayerWidget> m_player_widget;
// Not the piano keys, but the computer keyboard keys! // Not the piano keys, but the computer keyboard keys!

View file

@ -6,7 +6,7 @@
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
#include "KnobsWidget.h" #include "TrackControlsWidget.h"
#include "MainWidget.h" #include "MainWidget.h"
#include "ProcessorParameterWidget/ParameterWidget.h" #include "ProcessorParameterWidget/ParameterWidget.h"
#include "TrackManager.h" #include "TrackManager.h"
@ -16,7 +16,7 @@
#include <LibGUI/Slider.h> #include <LibGUI/Slider.h>
#include <LibGfx/Orientation.h> #include <LibGfx/Orientation.h>
KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget) TrackControlsWidget::TrackControlsWidget(TrackManager& track_manager, MainWidget& main_widget)
: m_track_manager(track_manager) : m_track_manager(track_manager)
, m_main_widget(main_widget) , m_main_widget(main_widget)
{ {
@ -52,7 +52,7 @@ KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget)
m_parameter_widgets.append(add<ProcessorParameterWidget>(parameter)); m_parameter_widgets.append(add<ProcessorParameterWidget>(parameter));
} }
void KnobsWidget::update_knobs() void TrackControlsWidget::update_knobs()
{ {
// FIXME: This is needed because when the slider is changed normally, we // FIXME: This is needed because when the slider is changed normally, we
// need to change the underlying value, but if the keyboard was used, we // need to change the underlying value, but if the keyboard was used, we

View file

@ -19,15 +19,15 @@
class TrackManager; class TrackManager;
class MainWidget; class MainWidget;
class KnobsWidget final : public GUI::Frame { class TrackControlsWidget final : public GUI::Frame {
C_OBJECT(KnobsWidget) C_OBJECT(TrackControlsWidget)
public: public:
virtual ~KnobsWidget() override = default; virtual ~TrackControlsWidget() override = default;
void update_knobs(); void update_knobs();
private: private:
KnobsWidget(TrackManager&, MainWidget&); TrackControlsWidget(TrackManager&, MainWidget&);
TrackManager& m_track_manager; TrackManager& m_track_manager;
MainWidget& m_main_widget; MainWidget& m_main_widget;