From cf985afdcb2fdeaf46f647aeb60ca83f242242f8 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Tue, 5 Sep 2023 11:37:06 +0200 Subject: [PATCH] LibWeb: Look for targetStepSHE in parent while creating child navigable Reported issue in the spec https://github.com/whatwg/html/issues/9686 --- Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp b/Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp index 4af92389a2..f20ff41155 100644 --- a/Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp +++ b/Userland/Libraries/LibWeb/HTML/NavigableContainer.cpp @@ -109,7 +109,8 @@ WebIDL::ExceptionOr NavigableContainer::create_new_child_navigable() auto parent_doc_state = parent_navigable->active_session_history_entry()->document_state; // 2. Let targetStepSHE be the first session history entry in traversable's session history entries whose document state equals parentDocState. - auto target_step_she = *(traversable->session_history_entries().find_if([parent_doc_state](auto& entry) { + // NOTE: We need to look for parent document state in parent navigable instead of traversable as specification says. https://github.com/whatwg/html/issues/9686 + auto target_step_she = *(parent_navigable->get_session_history_entries().find_if([parent_doc_state](auto& entry) { return entry->document_state == parent_doc_state; }));