RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 15:37:46 +00:00
Code Issues Activity Actions

LibJS: Turn initialize_global_object() into a regular initialize()

Browse source 
There's nothing special about global object initialization anymore, this
can just work the same way as for any other object now.
This commit is contained in:
Linus Groh 2022-08-28 14:42:50 +01:00
parent 867ad03995
commit cfa5885855
17 changed files with 36 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/WebContent/ConsoleGlobalObject.cpp
View file

@ -20,9 +20,9 @@ ConsoleGlobalObject::ConsoleGlobalObject(JS::Realm& realm, Web::Bindings::Window
{
}
void ConsoleGlobalObject::initialize_global_object(JS::Realm& realm)
void ConsoleGlobalObject::initialize(JS::Realm& realm)
{
Base::initialize_global_object(realm);
Base::initialize(realm);
// $0 magic variable
define_native_accessor(realm, "$0", inspected_node_getter, nullptr, 0);

3
Userland/Services/WebContent/ConsoleGlobalObject.h
View file

@ -21,6 +21,7 @@ class ConsoleGlobalObject final : public JS::GlobalObject {
public:
ConsoleGlobalObject(JS::Realm&, Web::Bindings::WindowObject&);
virtual void initialize(JS::Realm&) override;
virtual ~ConsoleGlobalObject() override = default;
virtual JS::ThrowCompletionOr<Object*> internal_get_prototype_of() const override;
@ -35,8 +36,6 @@ public:
virtual JS::ThrowCompletionOr<bool> internal_delete(JS::PropertyKey const& name) override;
virtual JS::ThrowCompletionOr<JS::MarkedVector<JS::Value>> internal_own_property_keys() const override;
virtual void initialize_global_object(JS::Realm&) override;
private:
virtual void visit_edges(Visitor&) override;

2
Userland/Services/WebContent/WebContentConsoleClient.cpp
View file

@ -33,7 +33,7 @@ WebContentConsoleClient::WebContentConsoleClient(JS::Console& console, WeakPtr<J
// It gets removed immediately after creating the interpreter in Document::interpreter().
auto& eso = verify_cast<Web::HTML::EnvironmentSettingsObject>(*realm.host_defined());
vm.push_execution_context(eso.realm_execution_context());
console_global_object->initialize_global_object(realm);
console_global_object->initialize(realm);
vm.pop_execution_context();
m_console_global_object = JS::make_handle(console_global_object);