RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:28:11 +00:00
Code Issues Activity Actions

LibWeb: Separate layout tree rendering into phases

Browse source 
CSS defines a very specific paint order. This patch starts steering us
towards respecting that by introducing the PaintPhase enum with values:

- Background
- Border
- Foreground
- Overlay (internal overlays used by inspector)

Basically, to get the right visual result, we have to render the page
multiple times, going one phase at a time.
This commit is contained in:
Andreas Kling 2020-06-18 18:57:35 +02:00
parent abe811104f
commit cfab53903f
22 changed files with 109 additions and 95 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Libraries/LibWeb/Layout/LayoutDocument.cpp
View file

@ -100,9 +100,17 @@ void LayoutDocument::did_set_viewport_rect(Badge<Frame>, const Gfx::IntRect& a_v
});
}
void LayoutDocument::render(RenderingContext& context)
void LayoutDocument::paint_all_phases(RenderingContext& context)
{
stacking_context()->render(context);
render(context, PaintPhase::Background);
render(context, PaintPhase::Border);
render(context, PaintPhase::Foreground);
render(context, PaintPhase::Overlay);
}
void LayoutDocument::render(RenderingContext& context, PaintPhase phase)
{
stacking_context()->render(context, phase);
}
}