From cfab81a96146aaf5b350c90b575870e53f7b9534 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Wed, 10 Apr 2019 15:46:56 +0200 Subject: [PATCH] WindowServer: Stop tracking whether clients have painted since last resize. This optimization is no longer needed now that clients coalesce resizes on their own. :^) --- Servers/WindowServer/WSClientConnection.cpp | 5 ----- Servers/WindowServer/WSWindow.h | 4 ---- Servers/WindowServer/WSWindowManager.cpp | 6 +----- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/Servers/WindowServer/WSClientConnection.cpp b/Servers/WindowServer/WSClientConnection.cpp index cfd3f4c99a..6937a3b59d 100644 --- a/Servers/WindowServer/WSClientConnection.cpp +++ b/Servers/WindowServer/WSClientConnection.cpp @@ -436,11 +436,6 @@ void WSClientConnection::handle_request(const WSAPIDidFinishPaintingNotification return; } auto& window = *(*it).value; - - if (!window.has_painted_since_last_resize()) { - window.set_has_painted_since_last_resize(true); - WSMessageLoop::the().post_message(window, make(window.rect(), window.rect())); - } WSWindowManager::the().invalidate(window, request.rect()); } diff --git a/Servers/WindowServer/WSWindow.h b/Servers/WindowServer/WSWindow.h index 60faf978f0..f4f43668de 100644 --- a/Servers/WindowServer/WSWindow.h +++ b/Servers/WindowServer/WSWindow.h @@ -106,9 +106,6 @@ public: bool has_alpha_channel() const { return m_has_alpha_channel; } void set_has_alpha_channel(bool value) { m_has_alpha_channel = value; } - bool has_painted_since_last_resize() const { return m_has_painted_since_last_resize; } - void set_has_painted_since_last_resize(bool b) { m_has_painted_since_last_resize = b; } - Size size_increment() const { return m_size_increment; } void set_size_increment(const Size& increment) { m_size_increment = increment; } @@ -138,7 +135,6 @@ private: bool m_automatic_cursor_tracking_enabled { false }; bool m_visible { true }; bool m_has_alpha_channel { false }; - bool m_has_painted_since_last_resize { false }; bool m_modal { false }; bool m_resizable { false }; bool m_listens_to_wm_events { false }; diff --git a/Servers/WindowServer/WSWindowManager.cpp b/Servers/WindowServer/WSWindowManager.cpp index bb3533d916..78795fec37 100644 --- a/Servers/WindowServer/WSWindowManager.cpp +++ b/Servers/WindowServer/WSWindowManager.cpp @@ -491,7 +491,6 @@ void WSWindowManager::start_window_resize(WSWindow& window, const WSMouseEvent& m_resize_window = window.make_weak_ptr();; m_resize_origin = event.position(); m_resize_window_original_rect = window.rect(); - m_resize_window->set_has_painted_since_last_resize(true); invalidate(window); } @@ -611,10 +610,7 @@ bool WSWindowManager::process_ongoing_window_resize(const WSMouseEvent& event, W new_rect.to_string().characters()); #endif m_resize_window->set_rect(new_rect); - if (m_resize_window->has_painted_since_last_resize()) { - m_resize_window->set_has_painted_since_last_resize(false); - WSMessageLoop::the().post_message(*m_resize_window, make(old_rect, new_rect)); - } + WSMessageLoop::the().post_message(*m_resize_window, make(old_rect, new_rect)); return true; }