RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-02 20:12:13 +00:00
Code Issues Activity Actions

LibJS: Support more assignment expressions in the bytecode VM

Browse source 
Use the new reference get/put helpers in BytecodeGenerator to support
assignment expressions other than just plain assignment.
This commit is contained in:
Andreas Kling 2021-10-25 15:29:52 +02:00
parent 72736f9e93
commit cfbb69a9cd
1 changed files with 91 additions and 118 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -253,16 +253,14 @@ void AssignmentExpression::generate_bytecode(Bytecode::Generator& generator) con
{
// FIXME: Implement this for BindingPatterns too.
auto& lhs = m_lhs.get<NonnullRefPtr<Expression>>();
if (is<Identifier>(*lhs)) {
auto& identifier = static_cast<Identifier const&>(*lhs);
if (m_op == AssignmentOp::Assignment) {
m_rhs->generate_bytecode(generator);
generator.emit<Bytecode::Op::SetVariable>(generator.intern_identifier(identifier.string()));
generator.emit_store_to_reference(lhs);
return;
}
lhs->generate_bytecode(generator);
generator.emit_load_from_reference(lhs);
Bytecode::BasicBlock* rhs_block_ptr { nullptr };
Bytecode::BasicBlock* end_block_ptr { nullptr };
@ -345,7 +343,7 @@ void AssignmentExpression::generate_bytecode(Bytecode::Generator& generator) con
TODO();
}
generator.emit<Bytecode::Op::SetVariable>(generator.intern_identifier(identifier.string()));
generator.emit_store_to_reference(lhs);
if (end_block_ptr) {
generator.emit<Bytecode::Op::Jump>().set_targets(
@ -354,31 +352,6 @@ void AssignmentExpression::generate_bytecode(Bytecode::Generator& generator) con
generator.switch_to_basic_block(*end_block_ptr);
}
return;
}
if (is<MemberExpression>(*lhs)) {
auto& expression = static_cast<MemberExpression const&>(*lhs);
expression.object().generate_bytecode(generator);
auto object_reg = generator.allocate_register();
generator.emit<Bytecode::Op::Store>(object_reg);
if (expression.is_computed()) {
expression.property().generate_bytecode(generator);
auto property_reg = generator.allocate_register();
generator.emit<Bytecode::Op::Store>(property_reg);
m_rhs->generate_bytecode(generator);
generator.emit<Bytecode::Op::PutByValue>(object_reg, property_reg);
} else {
m_rhs->generate_bytecode(generator);
auto identifier_table_ref = generator.intern_identifier(verify_cast<Identifier>(expression.property()).string());
generator.emit<Bytecode::Op::PutById>(object_reg, identifier_table_ref);
}
return;
}
TODO();
}
void WhileStatement::generate_bytecode(Bytecode::Generator& generator) const