From cfd141b4f9dc1352bdee22787a4c66fbac5127b5 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 4 Oct 2020 17:21:46 +0200 Subject: [PATCH] LibJS: Avoid unnecessary StringImpl copy in StringOrSymbol(String) --- Libraries/LibJS/Runtime/StringOrSymbol.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Libraries/LibJS/Runtime/StringOrSymbol.h b/Libraries/LibJS/Runtime/StringOrSymbol.h index ea66d2fcd0..01ca65b6ce 100644 --- a/Libraries/LibJS/Runtime/StringOrSymbol.h +++ b/Libraries/LibJS/Runtime/StringOrSymbol.h @@ -51,8 +51,10 @@ public: } StringOrSymbol(const String& string) - : m_ptr(StringImpl::create(string.characters(), string.length()).leak_ref()) + : m_ptr(string.impl()) { + ASSERT(!string.is_null()); + static_cast(m_ptr)->ref(); } ~StringOrSymbol()