1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:57:44 +00:00

LibJS: Implement Intl.NumberFormat V3's [[SignDisplay]] changes

Intl.NumberFormat V3 adds a "negative" option for [[SignDisplay]] to
only use the locale's signed pattern for negative numbers.
This commit is contained in:
Timothy Flynn 2022-07-12 15:07:52 -04:00 committed by Linus Groh
parent 733192089f
commit cff2d631da
3 changed files with 254 additions and 7 deletions

View file

@ -347,6 +347,20 @@ describe("style=decimal", () => {
expect(ar.format(-1)).toBe("\u061c-\u0661");
});
test("signDisplay=negative", () => {
const en = new Intl.NumberFormat("en", { signDisplay: "negative" });
expect(en.format(0)).toBe("0");
expect(en.format(1)).toBe("1");
expect(en.format(-0)).toBe("0");
expect(en.format(-1)).toBe("-1");
const ar = new Intl.NumberFormat("ar", { signDisplay: "negative" });
expect(ar.format(0)).toBe("\u0660");
expect(ar.format(1)).toBe("\u0661");
expect(ar.format(-0)).toBe("\u0660");
expect(ar.format(-1)).toBe("\u061c-\u0661");
});
test("useGrouping=always", () => {
const en = new Intl.NumberFormat("en", { useGrouping: "always" });
expect(en.format(123)).toBe("123");
@ -626,6 +640,20 @@ describe("style=percent", () => {
expect(ar.format(-0.0)).toBe("\u0660\u066a\u061c");
expect(ar.format(-0.01)).toBe("\u061c-\u0661\u066a\u061c");
});
test("signDisplay=negative", () => {
const en = new Intl.NumberFormat("en", { style: "percent", signDisplay: "negative" });
expect(en.format(0.0)).toBe("0%");
expect(en.format(0.01)).toBe("1%");
expect(en.format(-0.0)).toBe("0%");
expect(en.format(-0.01)).toBe("-1%");
const ar = new Intl.NumberFormat("ar", { style: "percent", signDisplay: "negative" });
expect(ar.format(0.0)).toBe("\u0660\u066a\u061c");
expect(ar.format(0.01)).toBe("\u0661\u066a\u061c");
expect(ar.format(-0.0)).toBe("\u0660\u066a\u061c");
expect(ar.format(-0.01)).toBe("\u061c-\u0661\u066a\u061c");
});
});
describe("style=currency", () => {
@ -952,6 +980,50 @@ describe("style=currency", () => {
expect(ar2.format(-0)).toBe("\u0660\u066b\u0660\u0660\u00a0US$");
expect(ar2.format(-1)).toBe("\u061c-\u0661\u066b\u0660\u0660\u00a0US$");
});
test("signDisplay=negative", () => {
const en1 = new Intl.NumberFormat("en", {
style: "currency",
currency: "USD",
signDisplay: "negative",
});
expect(en1.format(0)).toBe("$0.00");
expect(en1.format(1)).toBe("$1.00");
expect(en1.format(-0)).toBe("$0.00");
expect(en1.format(-1)).toBe("-$1.00");
const en2 = new Intl.NumberFormat("en", {
style: "currency",
currency: "USD",
currencySign: "accounting",
signDisplay: "negative",
});
expect(en2.format(0)).toBe("$0.00");
expect(en2.format(1)).toBe("$1.00");
expect(en2.format(-0)).toBe("$0.00");
expect(en2.format(-1)).toBe("($1.00)");
const ar1 = new Intl.NumberFormat("ar", {
style: "currency",
currency: "USD",
signDisplay: "negative",
});
expect(ar1.format(0)).toBe("\u0660\u066b\u0660\u0660\u00a0US$");
expect(ar1.format(1)).toBe("\u0661\u066b\u0660\u0660\u00a0US$");
expect(ar1.format(-0)).toBe("\u0660\u066b\u0660\u0660\u00a0US$");
expect(ar1.format(-1)).toBe("\u061c-\u0661\u066b\u0660\u0660\u00a0US$");
const ar2 = new Intl.NumberFormat("ar", {
style: "currency",
currency: "USD",
currencySign: "accounting",
signDisplay: "negative",
});
expect(ar2.format(0)).toBe("\u0660\u066b\u0660\u0660\u00a0US$");
expect(ar2.format(1)).toBe("\u0661\u066b\u0660\u0660\u00a0US$");
expect(ar2.format(-0)).toBe("\u0660\u066b\u0660\u0660\u00a0US$");
expect(ar2.format(-1)).toBe("\u061c-\u0661\u066b\u0660\u0660\u00a0US$");
});
});
describe("style=unit", () => {

View file

@ -171,6 +171,26 @@ describe("style=decimal", () => {
]);
});
test("signDisplay=negative", () => {
const en = new Intl.NumberFormat("en", { signDisplay: "negative" });
expect(en.formatToParts(0)).toEqual([{ type: "integer", value: "0" }]);
expect(en.formatToParts(1)).toEqual([{ type: "integer", value: "1" }]);
expect(en.formatToParts(-0)).toEqual([{ type: "integer", value: "0" }]);
expect(en.formatToParts(-1)).toEqual([
{ type: "minusSign", value: "-" },
{ type: "integer", value: "1" },
]);
const ar = new Intl.NumberFormat("ar", { signDisplay: "negative" });
expect(ar.formatToParts(0)).toEqual([{ type: "integer", value: "\u0660" }]);
expect(ar.formatToParts(1)).toEqual([{ type: "integer", value: "\u0661" }]);
expect(ar.formatToParts(-0)).toEqual([{ type: "integer", value: "\u0660" }]);
expect(ar.formatToParts(-1)).toEqual([
{ type: "minusSign", value: "\u061c-" },
{ type: "integer", value: "\u0661" },
]);
});
test("useGrouping=always", () => {
const en = new Intl.NumberFormat("en", { useGrouping: "always" });
expect(en.formatToParts(1234)).toEqual([
@ -588,6 +608,46 @@ describe("style=percent", () => {
{ type: "percentSign", value: "\u066a\u061c" },
]);
});
test("signDisplay=negative", () => {
const en = new Intl.NumberFormat("en", { style: "percent", signDisplay: "negative" });
expect(en.formatToParts(0.0)).toEqual([
{ type: "integer", value: "0" },
{ type: "percentSign", value: "%" },
]);
expect(en.formatToParts(0.01)).toEqual([
{ type: "integer", value: "1" },
{ type: "percentSign", value: "%" },
]);
expect(en.formatToParts(-0.0)).toEqual([
{ type: "integer", value: "0" },
{ type: "percentSign", value: "%" },
]);
expect(en.formatToParts(-0.01)).toEqual([
{ type: "minusSign", value: "-" },
{ type: "integer", value: "1" },
{ type: "percentSign", value: "%" },
]);
const ar = new Intl.NumberFormat("ar", { style: "percent", signDisplay: "negative" });
expect(ar.formatToParts(0.0)).toEqual([
{ type: "integer", value: "\u0660" },
{ type: "percentSign", value: "\u066a\u061c" },
]);
expect(ar.formatToParts(0.01)).toEqual([
{ type: "integer", value: "\u0661" },
{ type: "percentSign", value: "\u066a\u061c" },
]);
expect(ar.formatToParts(-0.0)).toEqual([
{ type: "integer", value: "\u0660" },
{ type: "percentSign", value: "\u066a\u061c" },
]);
expect(ar.formatToParts(-0.01)).toEqual([
{ type: "minusSign", value: "\u061c-" },
{ type: "integer", value: "\u0661" },
{ type: "percentSign", value: "\u066a\u061c" },
]);
});
});
describe("style=currency", () => {
@ -1133,6 +1193,107 @@ describe("style=currency", () => {
{ type: "literal", value: ")" },
]);
});
test("signDisplay=negative", () => {
const en = new Intl.NumberFormat("en", {
style: "currency",
currency: "USD",
signDisplay: "negative",
});
expect(en.formatToParts(0)).toEqual([
{ type: "currency", value: "$" },
{ type: "integer", value: "0" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "00" },
]);
expect(en.formatToParts(1)).toEqual([
{ type: "currency", value: "$" },
{ type: "integer", value: "1" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "00" },
]);
expect(en.formatToParts(-0)).toEqual([
{ type: "currency", value: "$" },
{ type: "integer", value: "0" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "00" },
]);
expect(en.formatToParts(-1)).toEqual([
{ type: "minusSign", value: "-" },
{ type: "currency", value: "$" },
{ type: "integer", value: "1" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "00" },
]);
const ar = new Intl.NumberFormat("ar", {
style: "currency",
currency: "USD",
signDisplay: "negative",
});
expect(ar.formatToParts(0)).toEqual([
{ type: "integer", value: "\u0660" },
{ type: "decimal", value: "\u066b" },
{ type: "fraction", value: "\u0660\u0660" },
{ type: "literal", value: "\u00a0" },
{ type: "currency", value: "US$" },
]);
expect(ar.formatToParts(1)).toEqual([
{ type: "integer", value: "\u0661" },
{ type: "decimal", value: "\u066b" },
{ type: "fraction", value: "\u0660\u0660" },
{ type: "literal", value: "\u00a0" },
{ type: "currency", value: "US$" },
]);
expect(ar.formatToParts(-0)).toEqual([
{ type: "integer", value: "\u0660" },
{ type: "decimal", value: "\u066b" },
{ type: "fraction", value: "\u0660\u0660" },
{ type: "literal", value: "\u00a0" },
{ type: "currency", value: "US$" },
]);
expect(ar.formatToParts(-1)).toEqual([
{ type: "minusSign", value: "\u061c-" },
{ type: "integer", value: "\u0661" },
{ type: "decimal", value: "\u066b" },
{ type: "fraction", value: "\u0660\u0660" },
{ type: "literal", value: "\u00a0" },
{ type: "currency", value: "US$" },
]);
const zh = new Intl.NumberFormat("zh-Hant-u-nu-hanidec", {
style: "currency",
currency: "USD",
currencySign: "accounting",
signDisplay: "negative",
});
expect(zh.formatToParts(0)).toEqual([
{ type: "currency", value: "US$" },
{ type: "integer", value: "" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "" },
]);
expect(zh.formatToParts(1)).toEqual([
{ type: "currency", value: "US$" },
{ type: "integer", value: "一" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "" },
]);
expect(zh.formatToParts(-0)).toEqual([
{ type: "currency", value: "US$" },
{ type: "integer", value: "" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "" },
]);
expect(zh.formatToParts(-1)).toEqual([
{ type: "literal", value: "(" },
{ type: "currency", value: "US$" },
{ type: "integer", value: "一" },
{ type: "decimal", value: "." },
{ type: "fraction", value: "" },
{ type: "literal", value: ")" },
]);
});
});
describe("style=unit", () => {