RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-13 17:42:08 +00:00
Code Issues Activity Actions

Shell: Resolve nonexistent string env variables to the empty string

Browse source 
We did this for lists, but not for strings.
This commit is contained in:
Ali Mohammad Pur 2023-03-21 04:03:01 +03:30 • committed by Andreas Kling
parent d997b794fa
commit d0112d76e9
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Shell/AST.cpp
View file

@ -3802,7 +3802,10 @@ ErrorOr<String> SimpleVariableValue::resolve_as_string(RefPtr<Shell> shell)
return resolve_slices(shell, TRY(value->resolve_as_string(shell)), m_slices); return resolve_slices(shell, TRY(value->resolve_as_string(shell)), m_slices);
auto name = m_name.to_deprecated_string(); auto name = m_name.to_deprecated_string();
char* env_value = getenv(name.characters()); char const* env_value = getenv(name.characters());
if (!env_value)
env_value = "";
return resolve_slices(shell, TRY(String::from_utf8(StringView { env_value, strlen(env_value) })), m_slices); return resolve_slices(shell, TRY(String::from_utf8(StringView { env_value, strlen(env_value) })), m_slices);
} }