RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

LibJS: Add StringOrSymbol constructor that takes a FlyString

Browse source 
This avoids refcount churn from implicit conversion in some places.
This commit is contained in:
Andreas Kling 2020-10-04 17:36:12 +02:00
parent 3d053f244f
commit d01b746d88
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Runtime/StringOrSymbol.h
View file

@ -26,6 +26,7 @@
#pragma once #pragma once
#include <AK/FlyString.h>
#include <LibJS/Runtime/PrimitiveString.h> #include <LibJS/Runtime/PrimitiveString.h>
#include <LibJS/Runtime/Symbol.h> #include <LibJS/Runtime/Symbol.h>
#include <LibJS/Runtime/Value.h> #include <LibJS/Runtime/Value.h>
@ -58,6 +59,13 @@ public:
static_cast<const StringImpl*>(m_ptr)->ref(); static_cast<const StringImpl*>(m_ptr)->ref();
} }
StringOrSymbol(const FlyString& string)
: m_ptr(string.impl())
{
ASSERT(!string.is_null());
static_cast<const StringImpl*>(m_ptr)->ref();
}
~StringOrSymbol() ~StringOrSymbol()
{ {
if (is_string()) if (is_string())