RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:37:44 +00:00
Code Issues Activity Actions

Tests+Base: Convert stack-smash to be LibTest based and stop skipping it

Browse source 
Now that the test is converted to be LibTest based, we can remove it
from the exclude list in /home/anon/.config/Tests.ini.

Prior to this it would crash and fail because it was signaled instead of
returning normally with exit code 0.
This commit is contained in:
Andrew Kaster 2021-06-30 22:40:03 -06:00 • committed by Andreas Kling
parent f0d562131f
commit d0447f23b8
3 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

36
Tests/LibC/TestStackSmash.cpp Normal file
View file

@ -0,0 +1,36 @@
/*
* Copyright (c) 2021, Brian Gianforcaro <bgianf@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/Format.h>
#include <LibTest/TestCase.h>
// Note: Needs to be 'noline' so stack canary isn't optimized out.
static void __attribute__((noinline)) smasher(char* string)
{
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Warray-bounds"
for (int i = 0; i < 256; i++) {
string[i] = 'A';
}
#pragma GCC diagnostic pop
}
// Note: Needs to be 'noline' so stack canary isn't optimized out.
static void __attribute__((noinline)) stack_to_smash()
{
char string[8] = {};
smasher(string);
}
TEST_CASE(stack_smash)
{
EXPECT_CRASH("Smash the stack and trigger __stack_chk_fail", [] {
outln("[+] Starting the stack smash...");
stack_to_smash();
outln("[+] Stack smash wasn't detected!");
return Test::Crash::Failure::DidNotCrash;
});
}