From d065de1fcf0bf1020e905fc584ee516c4ae378ee Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 4 Sep 2021 12:46:59 +0200 Subject: [PATCH] Kernel: Add missing error check when opening TTY for a new process --- Kernel/Process.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Kernel/Process.cpp b/Kernel/Process.cpp index 8e1ce6eaa7..f7e8034f63 100644 --- a/Kernel/Process.cpp +++ b/Kernel/Process.cpp @@ -164,7 +164,12 @@ RefPtr Process::create_user_process(RefPtr& first_thread, const return {}; } auto& device_to_use_as_tty = tty ? (CharacterDevice&)*tty : NullDevice::the(); - auto description = device_to_use_as_tty.open(O_RDWR).value(); + auto description_or_error = device_to_use_as_tty.open(O_RDWR); + if (description_or_error.is_error()) { + error = description_or_error.error().error(); + return {}; + } + auto& description = description_or_error.value(); auto setup_description = [&process, &description](int fd) { process->m_fds.m_fds_metadatas[fd].allocate();