RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:57:44 +00:00
Code Issues Activity Actions

Kernel: Stop debug spam when using mmap on /dev/mem device

Browse source 
This is not really useful and quite annoying so let's disable it by
default.
This commit is contained in:
Liav A 2022-04-01 19:52:22 +03:00 • committed by Andreas Kling
parent 916e093d4a
commit d0abae8907
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Debug.h.in
View file

@ -207,6 +207,10 @@
#cmakedefine01 MOUSE_DEBUG #cmakedefine01 MOUSE_DEBUG
#endif #endif
#ifndef MEMORY_DEVICE_DEBUG
#cmakedefine01 MEMORY_DEVICE_DEBUG
#endif
#ifndef MULTIPROCESSOR_DEBUG #ifndef MULTIPROCESSOR_DEBUG
#cmakedefine01 MULTIPROCESSOR_DEBUG #cmakedefine01 MULTIPROCESSOR_DEBUG
#endif #endif

4
Kernel/Devices/MemoryDevice.cpp
View file

@ -57,15 +57,13 @@ ErrorOr<Memory::Region*> MemoryDevice::mmap(Process& process, OpenFileDescriptio
// is to be set to the page base of that start address. // is to be set to the page base of that start address.
VERIFY(viewed_address == viewed_address.page_base()); VERIFY(viewed_address == viewed_address.page_base());
dbgln("MemoryDevice: Trying to mmap physical memory at {} for range of {} bytes", viewed_address, range.size());
if (!MM.is_allowed_to_read_physical_memory_for_userspace(viewed_address, range.size())) { if (!MM.is_allowed_to_read_physical_memory_for_userspace(viewed_address, range.size())) {
dbgln("MemoryDevice: Trying to mmap physical memory at {} for range of {} bytes failed due to violation of access", viewed_address, range.size()); dbgln_if(MEMORY_DEVICE_DEBUG, "MemoryDevice: Trying to mmap physical memory at {} for range of {} bytes failed due to violation of access", viewed_address, range.size());
return EINVAL; return EINVAL;
} }
auto vmobject = TRY(Memory::AnonymousVMObject::try_create_for_physical_range(viewed_address, range.size())); auto vmobject = TRY(Memory::AnonymousVMObject::try_create_for_physical_range(viewed_address, range.size()));
dbgln("MemoryDevice: Mapped physical memory at {} for range of {} bytes", viewed_address, range.size());
return process.address_space().allocate_region_with_vmobject( return process.address_space().allocate_region_with_vmobject(
range, range,
move(vmobject), move(vmobject),

1
Meta/CMake/all_the_debug_macros.cmake
View file

@ -117,6 +117,7 @@ set(MATROSKA_DEBUG ON)
set(MATROSKA_TRACE_DEBUG ON) set(MATROSKA_TRACE_DEBUG ON)
set(MASTERPTY_DEBUG ON) set(MASTERPTY_DEBUG ON)
set(MBR_DEBUG ON) set(MBR_DEBUG ON)
set(MEMORY_DEVICE_DEBUG ON)
set(MEMORY_DEBUG ON) set(MEMORY_DEBUG ON)
set(MENU_DEBUG ON) set(MENU_DEBUG ON)
set(MENUS_DEBUG ON) set(MENUS_DEBUG ON)