RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 00:32:45 +00:00
Code Issues Activity Actions

LibWeb: Convert video control dimensions from CSSPixels to DevicePixels

Browse source 
Rather than storing static DevicePixels dimensions, treat the desired
pixel sizes as CSSPixels and convert them to DevicePixels.

This was originally developed on a mac with a device-to-CSS-pixel ratio
of 2. Running it on another machine with a ratio of 1 made the controls
appear huge.
This commit is contained in:
Timothy Flynn 2023-04-10 06:56:22 -04:00 • committed by Tim Flynn
parent d05d938e73
commit d0e18b8a17
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Painting/VideoPaintable.cpp
View file

@ -86,9 +86,9 @@ void VideoPaintable::paint(PaintContext& context, PaintPhase phase) const
void VideoPaintable::paint_loaded_video_controls(PaintContext& context, HTML::HTMLVideoElement const& video_element, DevicePixelRect video_rect, Optional<DevicePixelPoint> const& mouse_position) const
{
static constexpr DevicePixels maximum_control_box_size = 60;
static constexpr DevicePixels maximum_playback_button_size = 30;
static constexpr DevicePixels maximum_playback_button_offset_x = 30;
auto maximum_control_box_size = context.rounded_device_pixels(30);
auto maximum_playback_button_size = context.rounded_device_pixels(15);
auto maximum_playback_button_offset_x = context.rounded_device_pixels(15);
auto is_hovered = document().hovered_node() == &video_element;
auto is_paused = video_element.paused();
@ -141,8 +141,8 @@ void VideoPaintable::paint_loaded_video_controls(PaintContext& context, HTML::HT
void VideoPaintable::paint_placeholder_video_controls(PaintContext& context, DevicePixelRect video_rect, Optional<DevicePixelPoint> const& mouse_position) const
{
static constexpr DevicePixels maximum_control_box_size = 200;
static constexpr DevicePixels maximum_playback_button_size = 80;
auto maximum_control_box_size = context.rounded_device_pixels(100);
auto maximum_playback_button_size = context.rounded_device_pixels(40);
auto center = video_rect.center();