RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-21 15:05:07 +00:00
Code Issues Activity Actions

LibWeb: Move PaintPhase enum out of Layout::Node

Browse source 
Now it's just Layout::PaintPhase instead of Layout::Node::PaintPhase.
This commit is contained in:
Andreas Kling 2020-12-03 19:15:27 +01:00
parent d6c2a61fa1
commit d129e68da8
4 changed files with 11 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/Forward.h
View file

@ -148,6 +148,7 @@ class SVGSVGElement;
namespace Web::Layout { namespace Web::Layout {
enum class LayoutMode; enum class LayoutMode;
enum class PaintPhase;
class BlockBox; class BlockBox;
class BlockFormattingContext; class BlockFormattingContext;
class Box; class Box;

16
Libraries/LibWeb/Layout/Node.h
View file

@ -46,6 +46,14 @@ enum class LayoutMode {
OnlyRequiredLineBreaks, OnlyRequiredLineBreaks,
}; };
enum class PaintPhase {
Background,
Border,
Foreground,
FocusOutline,
Overlay,
};
struct HitTestResult { struct HitTestResult {
RefPtr<Node> layout_node; RefPtr<Node> layout_node;
int index_in_node { 0 }; int index_in_node { 0 };
@ -117,14 +125,6 @@ public:
virtual void handle_mouseup(Badge<EventHandler>, const Gfx::IntPoint&, unsigned button, unsigned modifiers); virtual void handle_mouseup(Badge<EventHandler>, const Gfx::IntPoint&, unsigned button, unsigned modifiers);
virtual void handle_mousemove(Badge<EventHandler>, const Gfx::IntPoint&, unsigned buttons, unsigned modifiers); virtual void handle_mousemove(Badge<EventHandler>, const Gfx::IntPoint&, unsigned buttons, unsigned modifiers);
enum class PaintPhase {
Background,
Border,
Foreground,
FocusOutline,
Overlay,
};
virtual void before_children_paint(PaintContext&, PaintPhase) {}; virtual void before_children_paint(PaintContext&, PaintPhase) {};
virtual void paint(PaintContext&, PaintPhase); virtual void paint(PaintContext&, PaintPhase);
virtual void after_children_paint(PaintContext&, PaintPhase) {}; virtual void after_children_paint(PaintContext&, PaintPhase) {};

2
Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -47,7 +47,7 @@ StackingContext::StackingContext(Box& box, StackingContext* parent)
} }
} }
void StackingContext::paint(PaintContext& context, Node::PaintPhase phase) void StackingContext::paint(PaintContext& context, PaintPhase phase)
{ {
if (!m_box.is_root()) { if (!m_box.is_root()) {
m_box.paint(context, phase); m_box.paint(context, phase);

2
Libraries/LibWeb/Painting/StackingContext.h
View file

@ -38,7 +38,7 @@ public:
StackingContext* parent() { return m_parent; } StackingContext* parent() { return m_parent; }
const StackingContext* parent() const { return m_parent; } const StackingContext* parent() const { return m_parent; }
void paint(PaintContext&, Layout::Node::PaintPhase); void paint(PaintContext&, PaintPhase);
HitTestResult hit_test(const Gfx::IntPoint&, HitTestType) const; HitTestResult hit_test(const Gfx::IntPoint&, HitTestType) const;
void dump(int indent = 0) const; void dump(int indent = 0) const;