RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:37:35 +00:00
Code Issues Activity Actions

Kernel: Merge {get,set}_process_name syscalls to the prctl syscall

Browse source 
It makes much more sense to have these actions being performed via the
prctl syscall, as they both require 2 plain arguments to be passed to
the syscall layer, and in contrast to most syscalls, we don't get in
these removed syscalls an automatic representation of Userspace<T>, but
two FlatPtr(s) to perform casting on them in the prctl syscall which is
suited to what has been done in the removed syscalls.

Also, it makes sense to have these actions in the prctl syscall, because
they are strongly related to the process control concept of the prctl
syscall.
This commit is contained in:
Liav A 2023-03-03 15:47:39 +02:00 • committed by Jelle Raaijmakers
parent 1e36d54493
commit d16d805d96
9 changed files with 36 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Userland/DevTools/UserspaceEmulator/Emulator_syscalls.cpp
View file

@ -100,8 +100,6 @@ u32 Emulator::virt_syscall(u32 function, u32 arg1, u32 arg2, u32 arg3)
return virt$futex(arg1);
case SC_get_dir_entries:
return virt$get_dir_entries(arg1, arg2, arg3);
case SC_get_process_name:
return virt$get_process_name(arg1, arg2);
case SC_get_stack_bounds:
return virt$get_stack_bounds(arg1, arg2);
case SC_getcwd:
@ -210,8 +208,6 @@ u32 Emulator::virt_syscall(u32 function, u32 arg1, u32 arg2, u32 arg3)
return virt$sendmsg(arg1, arg2, arg3);
case SC_set_mmap_name:
return virt$set_mmap_name(arg1);
case SC_set_process_name:
return virt$set_process_name(arg1, arg2);
case SC_set_thread_name:
return virt$set_thread_name(arg1, arg2, arg3);
case SC_setgid:
@ -571,28 +567,6 @@ int Emulator::virt$set_mmap_name(FlatPtr params_addr)
return 0;
}
int Emulator::virt$get_process_name(FlatPtr buffer, int size)
{
if (size < 0)
return -EINVAL;
auto host_buffer_result = ByteBuffer::create_zeroed((size_t)size);
if (host_buffer_result.is_error())
return -ENOMEM;
auto& host_buffer = host_buffer_result.value();
int rc = syscall(SC_get_process_name, host_buffer.data(), host_buffer.size());
mmu().copy_to_vm(buffer, host_buffer.data(), host_buffer.size());
return rc;
}
int Emulator::virt$set_process_name(FlatPtr user_buffer, int size)
{
if (size < 0)
return -EINVAL;
auto host_buffer = mmu().copy_buffer_from_vm(user_buffer, size);
auto name = DeprecatedString::formatted("(UE) {}", StringView { host_buffer.data(), host_buffer.size() });
return syscall(SC_set_process_name, name.characters(), name.length());
}
int Emulator::virt$lseek(int fd, FlatPtr offset_addr, int whence)
{
off_t offset;