RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:17:44 +00:00
Code Issues Activity Actions

LibJS: Avoid unnecessary SourceRange construction in parse_program()

Browse source 
This takes `test-js` runtime from 4.3 sec to 4.1 sec on my machine.
This commit is contained in:
Andreas Kling 2022-11-24 15:38:52 +01:00 • committed by Linus Groh
parent f0482b61bf
commit d16fab5815
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/AST.h
View file

@ -53,7 +53,9 @@ public:
virtual Bytecode::CodeGenerationErrorOr<void> generate_bytecode(Bytecode::Generator&) const; virtual Bytecode::CodeGenerationErrorOr<void> generate_bytecode(Bytecode::Generator&) const;
virtual void dump(int indent) const; virtual void dump(int indent) const;
SourceRange source_range() const; [[nodiscard]] SourceRange source_range() const;
void set_end_offset(Badge<Parser>, u32 end_offset) { m_end_offset = end_offset; }
String class_name() const; String class_name() const;

2
Userland/Libraries/LibJS/Parser.cpp
View file

@ -497,7 +497,7 @@ NonnullRefPtr<Program> Parser::parse_program(bool starts_in_strict_mode)
else else
parse_module(program); parse_module(program);
program->source_range().end = position(); program->set_end_offset({}, position().offset);
return program; return program;
} }