RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:27:43 +00:00
Code Issues Activity Actions

LookupServer: Don't cache already-expired DNS answers

Browse source
This commit is contained in:
Andreas Kling 2020-01-26 16:24:57 +01:00
parent 174583cda5
commit d1721c761e
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Servers/LookupServer/LookupServer.cpp
View file

@ -240,13 +240,18 @@ Vector<String> LookupServer::lookup(const String& hostname, bool& did_timeout, u
return {}; return {};
} }
Vector<String> responses; Vector<String, 8> responses;
Vector<DNSAnswer, 8> cacheable_answers;
for (auto& answer : response.answers()) { for (auto& answer : response.answers()) {
responses.append(answer.record_data()); responses.append(answer.record_data());
if (!answer.has_expired())
cacheable_answers.append(answer);
} }
if (m_lookup_cache.size() >= 256) if (!cacheable_answers.is_empty()) {
m_lookup_cache.remove(m_lookup_cache.begin()); if (m_lookup_cache.size() >= 256)
m_lookup_cache.set(hostname, { request.questions()[0], response.answers() }); m_lookup_cache.remove(m_lookup_cache.begin());
m_lookup_cache.set(hostname, { request.questions()[0], move(cacheable_answers) });
}
return responses; return responses;
} }