RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:48:14 +00:00
Code Issues Activity Actions

LibGUI: Make view widgets fill background by default

Browse source 
Most clients will want background autofill, so let's make it the
default mode.
This commit is contained in:
Andreas Kling 2020-04-18 21:55:37 +02:00
parent c7b7b65309
commit d17b42b28d
4 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibGUI/ItemView.cpp
View file

@ -39,6 +39,7 @@ namespace GUI {
ItemView::ItemView() ItemView::ItemView()
{ {
set_fill_with_background_color(true);
set_background_role(ColorRole::Base); set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText); set_foreground_role(ColorRole::BaseText);
horizontal_scrollbar().set_visible(false); horizontal_scrollbar().set_visible(false);

4
Libraries/LibGUI/ListView.cpp
View file

@ -35,6 +35,7 @@ namespace GUI {
ListView::ListView() ListView::ListView()
{ {
set_fill_with_background_color(true);
set_background_role(ColorRole::Base); set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText); set_foreground_role(ColorRole::BaseText);
} }
@ -170,7 +171,8 @@ void ListView::paint_event(PaintEvent& event)
}; };
Gfx::Rect unpainted_rect(0, painted_item_index * item_height(), exposed_width, height()); Gfx::Rect unpainted_rect(0, painted_item_index * item_height(), exposed_width, height());
painter.fill_rect(unpainted_rect, palette().color(background_role())); if (fill_with_background_color())
painter.fill_rect(unpainted_rect, palette().color(background_role()));
} }
int ListView::item_count() const int ListView::item_count() const

7
Libraries/LibGUI/TableView.cpp
View file

@ -40,6 +40,7 @@ namespace GUI {
TableView::TableView() TableView::TableView()
{ {
set_fill_with_background_color(true);
set_background_role(ColorRole::Base); set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText); set_foreground_role(ColorRole::BaseText);
} }
@ -56,7 +57,8 @@ void TableView::paint_event(PaintEvent& event)
Painter painter(*this); Painter painter(*this);
painter.add_clip_rect(frame_inner_rect()); painter.add_clip_rect(frame_inner_rect());
painter.add_clip_rect(event.rect()); painter.add_clip_rect(event.rect());
painter.fill_rect(event.rect(), widget_background_color); if (fill_with_background_color())
painter.fill_rect(event.rect(), widget_background_color);
painter.translate(frame_thickness(), frame_thickness()); painter.translate(frame_thickness(), frame_thickness());
painter.translate(-horizontal_scrollbar().value(), -vertical_scrollbar().value()); painter.translate(-horizontal_scrollbar().value(), -vertical_scrollbar().value());
@ -144,7 +146,8 @@ void TableView::paint_event(PaintEvent& event)
}; };
Gfx::Rect unpainted_rect(0, header_height() + painted_item_index * item_height(), exposed_width, height()); Gfx::Rect unpainted_rect(0, header_height() + painted_item_index * item_height(), exposed_width, height());
painter.fill_rect(unpainted_rect, widget_background_color); if (fill_with_background_color())
painter.fill_rect(unpainted_rect, widget_background_color);
// Untranslate the painter vertically and do the column headers. // Untranslate the painter vertically and do the column headers.
painter.translate(0, vertical_scrollbar().value()); painter.translate(0, vertical_scrollbar().value());

4
Libraries/LibGUI/TreeView.cpp
View file

@ -53,6 +53,7 @@ TreeView::MetadataForIndex& TreeView::ensure_metadata_for_index(const ModelIndex
TreeView::TreeView() TreeView::TreeView()
{ {
set_fill_with_background_color(true);
set_background_role(ColorRole::Base); set_background_role(ColorRole::Base);
set_foreground_role(ColorRole::BaseText); set_foreground_role(ColorRole::BaseText);
set_size_columns_to_fit_content(true); set_size_columns_to_fit_content(true);
@ -173,7 +174,8 @@ void TreeView::paint_event(PaintEvent& event)
Painter painter(*this); Painter painter(*this);
painter.add_clip_rect(frame_inner_rect()); painter.add_clip_rect(frame_inner_rect());
painter.add_clip_rect(event.rect()); painter.add_clip_rect(event.rect());
painter.fill_rect(event.rect(), palette().color(background_role())); if (fill_with_background_color())
painter.fill_rect(event.rect(), palette().color(background_role()));
if (!model()) if (!model())
return; return;