RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 09:57:35 +00:00
Code Issues Activity Actions

Kernel: Clearing promises with pledge("") should fail

Browse source 
Thanks Sergey for catching this brain-fart. :^)
This commit is contained in:
Andreas Kling 2020-01-12 12:14:08 +01:00
parent f813bb52a2
commit d1839ae0c9
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Process.cpp
View file

@ -4417,7 +4417,7 @@ int Process::sys$pledge(const Syscall::SC_pledge_params* user_params)
u32 new_promises = 0;
if (!parse_pledge(promises, new_promises))
return -EINVAL;
if (m_promises && new_promises & ~m_promises)
if (m_promises && (!new_promises || new_promises & ~m_promises))
return -EPERM;
m_promises = new_promises;
}
@ -4426,7 +4426,7 @@ int Process::sys$pledge(const Syscall::SC_pledge_params* user_params)
u32 new_execpromises = 0;
if (!parse_pledge(execpromises, new_execpromises))
return -EINVAL;
if (m_execpromises && new_execpromises & ~m_execpromises)
if (m_execpromises && (!new_execpromises || new_execpromises & ~m_execpromises))
return -EPERM;
m_execpromises = new_execpromises;
}