RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:48:11 +00:00
Code Issues Activity Actions

LibWeb: Add per-Frame EventHandler, handle mouse events recursively

Browse source 
We now handle mouse events by recursing into subframes. This makes
links, tooltips, etc, work inside <iframe> content.
This commit is contained in:
Andreas Kling 2020-06-07 14:40:38 +02:00
parent 896db187e5
commit d1852b4547
7 changed files with 355 additions and 144 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibWeb/PageView.h
View file

@ -29,13 +29,13 @@
#include <AK/URL.h>
#include <LibGUI/ScrollableWidget.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/Forward.h>
namespace Web {
class Frame;
class PageView : public GUI::ScrollableWidget {
C_OBJECT(PageView)
C_OBJECT(PageView);
public:
virtual ~PageView() override;
@ -75,6 +75,13 @@ public:
virtual bool accepts_focus() const override { return true; }
void notify_link_click(Badge<EventHandler>, Web::Frame&, const String& href, const String& target, unsigned modifiers);
void notify_link_middle_click(Badge<EventHandler>, Web::Frame&, const String& href, const String& target, unsigned modifiers);
void notify_link_context_menu_request(Badge<EventHandler>, Web::Frame&, const Gfx::Point& content_position, const String& href, const String& target, unsigned modifiers);
void notify_link_hover(Badge<EventHandler>, Web::Frame&, const String& href);
void notify_tooltip_area_enter(Badge<EventHandler>, Web::Frame&, const Gfx::Point& content_position, const String& title);
void notify_tooltip_area_leave(Badge<EventHandler>, Web::Frame&);
protected:
PageView();
@ -89,17 +96,13 @@ protected:
private:
virtual void did_scroll() override;
RefPtr<Document> create_document_from_mime_type(const ByteBuffer& data, const URL& url, const String& mime_type, const String& encoding);
Gfx::Point to_screen_position(const Web::Frame&, const Gfx::Point&) const;
void run_javascript_url(const String& url);
void layout_and_sync_size();
void dump_selection(const char* event_name);
Gfx::Point compute_mouse_event_offset(const Gfx::Point&, const LayoutNode&) const;
RefPtr<Web::Frame> m_main_frame;
bool m_should_show_line_box_borders { false };
bool m_in_mouse_selection { false };
};
}