From d196fbce5bb85f1726761345fa5de88d3cc3ddf4 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 23 Oct 2021 17:54:59 +0200 Subject: [PATCH] LibGUI: Repaint buttons immediately on mouse up/down events This ensures that rapidly clicking a button doesn't look like it's "swallowing" some of the mouse events. This already worked okay due to a hack in Window, but this will allow us to get rid of that hack. --- Userland/Libraries/LibGUI/AbstractButton.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibGUI/AbstractButton.cpp b/Userland/Libraries/LibGUI/AbstractButton.cpp index c3a66d61e2..d3f82f345a 100644 --- a/Userland/Libraries/LibGUI/AbstractButton.cpp +++ b/Userland/Libraries/LibGUI/AbstractButton.cpp @@ -116,7 +116,7 @@ void AbstractButton::mousedown_event(MouseEvent& event) { if (event.button() == MouseButton::Left) { m_being_pressed = true; - update(); + repaint(); if (m_auto_repeat_interval) { click(); @@ -134,7 +134,7 @@ void AbstractButton::mouseup_event(MouseEvent& event) m_auto_repeat_timer->stop(); bool was_being_pressed = m_being_pressed; m_being_pressed = false; - update(); + repaint(); if (was_being_pressed && !was_auto_repeating) click(event.modifiers()); }