RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

LibJS: Stop propagating small OOM errors from the String object

Browse source
This commit is contained in:
Timothy Flynn 2023-09-06 07:40:44 -04:00 • committed by Tim Flynn
parent 02a8683266
commit d1a1ace77a
4 changed files with 51 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/StringConstructor.cpp
View file

@ -51,7 +51,7 @@ ThrowCompletionOr<Value> StringConstructor::call()
// 2. Else,
// a. If NewTarget is undefined and value is a Symbol, return SymbolDescriptiveString(value).
if (value.is_symbol())
return PrimitiveString::create(vm, TRY_OR_THROW_OOM(vm, value.as_symbol().descriptive_string()));
return PrimitiveString::create(vm, MUST(value.as_symbol().descriptive_string()));
// b. Let s be ? ToString(value).
// 3. If NewTarget is undefined, return s.
@ -126,7 +126,7 @@ JS_DEFINE_NATIVE_FUNCTION(StringConstructor::from_code_point)
return vm.throw_completion<RangeError>(ErrorType::InvalidCodePoint, next_code_point.to_string_without_side_effects());
// d. Set result to the string-concatenation of result and UTF16EncodeCodePoint(ℝ(nextCP)).
TRY_OR_THROW_OOM(vm, code_point_to_utf16(string, static_cast<u32>(code_point)));
MUST(code_point_to_utf16(string, static_cast<u32>(code_point)));
}
// 3. Assert: If codePoints is empty, then result is the empty String.