From d1a72dc6ebe2d9a7146056b12d3bd1be1f338762 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Mon, 10 May 2021 11:54:01 +0100 Subject: [PATCH] LibJS/Tests: Rename function parameter from 'arguments' to 'arguments_' The former has a special meaning and should be avoided where possible. --- .../Tests/builtins/Proxy/Proxy.handler-apply.js | 8 +++++--- .../builtins/Proxy/Proxy.handler-construct.js | 16 ++++++++++------ 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-apply.js b/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-apply.js index 0e59d4f473..f3b31ba751 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-apply.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-apply.js @@ -11,11 +11,13 @@ describe("[[Call]] trap normal behavior", () => { test("correct arguments supplied to trap", () => { const f = (a, b) => a + b; const handler = { - apply(target, this_, arguments) { + apply(target, this_, arguments_) { expect(target).toBe(f); expect(this_).toBe(handler); - if (arguments[2]) return arguments[0] * arguments[1]; - return f(...arguments); + if (arguments_[2]) { + return arguments_[0] * arguments_[1]; + } + return f(...arguments_); }, }; p = new Proxy(f, handler); diff --git a/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-construct.js b/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-construct.js index 73a63346a3..850731d2e5 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-construct.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Proxy/Proxy.handler-construct.js @@ -27,11 +27,13 @@ describe("[[Construct]] trap normal behavior", () => { let p; const handler = { - construct(target, arguments, newTarget) { + construct(target, arguments_, newTarget) { expect(target).toBe(f); expect(newTarget).toBe(p); - if (arguments[1]) return Reflect.construct(target, [arguments[0] * 2], newTarget); - return Reflect.construct(target, arguments, newTarget); + if (arguments_[1]) { + return Reflect.construct(target, [arguments_[0] * 2], newTarget); + } + return Reflect.construct(target, arguments_, newTarget); }, }; p = new Proxy(f, handler); @@ -48,11 +50,13 @@ describe("[[Construct]] trap normal behavior", () => { let p; function theNewTarget() {} const handler = { - construct(target, arguments, newTarget) { + construct(target, arguments_, newTarget) { expect(target).toBe(f); expect(newTarget).toBe(theNewTarget); - if (arguments[1]) return Reflect.construct(target, [arguments[0] * 2], newTarget); - return Reflect.construct(target, arguments, newTarget); + if (arguments_[1]) { + return Reflect.construct(target, [arguments_[0] * 2], newTarget); + } + return Reflect.construct(target, arguments_, newTarget); }, }; p = new Proxy(f, handler);