RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:17:36 +00:00
Code Issues Activity Actions

LibJS: Fix .length attributes of various native functions

Browse source 
Namely the Proxy revocation, Promise resolving, Promise then/catch
finally, and Promise GetCapabilitiesExecutor functions.
They were all missing an explicit 'Attribute::Configurable' argument
and therefore incorrectly used the default attributes (writable,
enumerable, configurable).
This commit is contained in:
Linus Groh 2021-06-17 13:10:06 +01:00
parent 631d36fd98
commit d1c109be96
4 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/PromisePrototype.cpp
View file

@ -105,7 +105,7 @@ JS_DEFINE_NATIVE_FUNCTION(PromisePrototype::finally)
}); });
return promise->invoke(vm.names.then.as_string(), value_thunk); return promise->invoke(vm.names.then.as_string(), value_thunk);
}); });
then_finally_function->define_property(vm.names.length, Value(1)); then_finally_function->define_property(vm.names.length, Value(1), Attribute::Configurable);
// 27.2.5.3.2 Catch Finally Functions, https://tc39.es/ecma262/#sec-catchfinallyfunctions // 27.2.5.3.2 Catch Finally Functions, https://tc39.es/ecma262/#sec-catchfinallyfunctions
auto* catch_finally_function = NativeFunction::create(global_object, "", [constructor_handle = make_handle(constructor), on_finally_handle = make_handle(&on_finally.as_function())](auto& vm, auto& global_object) -> Value { auto* catch_finally_function = NativeFunction::create(global_object, "", [constructor_handle = make_handle(constructor), on_finally_handle = make_handle(&on_finally.as_function())](auto& vm, auto& global_object) -> Value {
@ -124,7 +124,7 @@ JS_DEFINE_NATIVE_FUNCTION(PromisePrototype::finally)
}); });
return promise->invoke(vm.names.then.as_string(), thrower); return promise->invoke(vm.names.then.as_string(), thrower);
}); });
catch_finally_function->define_property(vm.names.length, Value(1)); catch_finally_function->define_property(vm.names.length, Value(1), Attribute::Configurable);
then_finally = Value(then_finally_function); then_finally = Value(then_finally_function);
catch_finally = Value(catch_finally_function); catch_finally = Value(catch_finally_function);

3
Userland/Libraries/LibJS/Runtime/PromiseReaction.cpp
View file

@ -25,6 +25,7 @@ PromiseCapability new_promise_capability(GlobalObject& global_object, Value cons
Value reject { js_undefined() }; Value reject { js_undefined() };
} promise_capability_functions; } promise_capability_functions;
// 27.2.1.5.1 GetCapabilitiesExecutor Functions, https://tc39.es/ecma262/#sec-getcapabilitiesexecutor-functions
auto* executor = NativeFunction::create(global_object, "", [&promise_capability_functions](auto& vm, auto& global_object) -> Value { auto* executor = NativeFunction::create(global_object, "", [&promise_capability_functions](auto& vm, auto& global_object) -> Value {
auto resolve = vm.argument(0); auto resolve = vm.argument(0);
auto reject = vm.argument(1); auto reject = vm.argument(1);
@ -41,7 +42,7 @@ PromiseCapability new_promise_capability(GlobalObject& global_object, Value cons
promise_capability_functions.reject = reject; promise_capability_functions.reject = reject;
return js_undefined(); return js_undefined();
}); });
executor->define_property(vm.names.length, Value(2)); executor->define_property(vm.names.length, Value(2), Attribute::Configurable);
MarkedValueList arguments(vm.heap()); MarkedValueList arguments(vm.heap());
arguments.append(executor); arguments.append(executor);

2
Userland/Libraries/LibJS/Runtime/PromiseResolvingFunction.cpp
View file

@ -27,7 +27,7 @@ PromiseResolvingFunction::PromiseResolvingFunction(Promise& promise, AlreadyReso
void PromiseResolvingFunction::initialize(GlobalObject& global_object) void PromiseResolvingFunction::initialize(GlobalObject& global_object)
{ {
Base::initialize(global_object); Base::initialize(global_object);
define_property(vm().names.length, Value(1)); define_property(vm().names.length, Value(1), Attribute::Configurable);
} }
Value PromiseResolvingFunction::call() Value PromiseResolvingFunction::call()

2
Userland/Libraries/LibJS/Runtime/ProxyConstructor.cpp
View file

@ -79,7 +79,7 @@ JS_DEFINE_NATIVE_FUNCTION(ProxyConstructor::revocable)
proxy.revoke(); proxy.revoke();
return js_undefined(); return js_undefined();
}); });
revoker->define_property(vm.names.length, Value(0)); revoker->define_property(vm.names.length, Value(0), Attribute::Configurable);
auto* result = Object::create(global_object, global_object.object_prototype()); auto* result = Object::create(global_object, global_object.object_prototype());
result->define_property(vm.names.proxy, proxy); result->define_property(vm.names.proxy, proxy);