RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:27:43 +00:00
Code Issues Activity Actions

Everywhere: Redundant inline specifier on constexpr functions (#3807)

Browse source 
Problem:
- `constexpr` functions are decorated with the `inline` specifier
  keyword. This is redundant because `constexpr` functions are
  implicitly `inline`.
- [dcl.constexpr], §7.1.5/2 in the C++11 standard): "constexpr
  functions and constexpr constructors are implicitly inline (7.1.2)".

Solution:
- Remove the redundant `inline` keyword.
This commit is contained in:
Lenny Maiorani 2020-10-20 10:08:13 -06:00 • committed by GitHub
parent a40abd6ce3
commit d1fe6a0b53
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 43 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Arch/i386/CPU.h
View file

@ -499,7 +499,7 @@ struct [[gnu::aligned(16)]] FPUState
u8 buffer[512];
};
inline constexpr FlatPtr page_base_of(FlatPtr address)
constexpr FlatPtr page_base_of(FlatPtr address)
{
return address & PAGE_MASK;
}
@ -509,7 +509,7 @@ inline FlatPtr page_base_of(const void* address)
return page_base_of((FlatPtr)address);
}
inline constexpr FlatPtr offset_in_page(FlatPtr address)
constexpr FlatPtr offset_in_page(FlatPtr address)
{
return address & (~PAGE_MASK);
}