From d209d5a84f7f9fd75e4727418552c016978d395e Mon Sep 17 00:00:00 2001 From: Tim Ledbetter Date: Sat, 24 Feb 2024 07:46:59 +0000 Subject: [PATCH] LibWeb: Ensure CSSStyleSheet::css_rules() always returns the same object Instead of having a method that replaces the stylesheet's CSSRuleList, we now have a method on CSSRuleList to modify it's underlying CSSRules. --- Userland/Libraries/LibWeb/CSS/CSSRuleList.h | 2 ++ Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/CSS/CSSRuleList.h b/Userland/Libraries/LibWeb/CSS/CSSRuleList.h index f28235046f..70cb9c013d 100644 --- a/Userland/Libraries/LibWeb/CSS/CSSRuleList.h +++ b/Userland/Libraries/LibWeb/CSS/CSSRuleList.h @@ -62,6 +62,8 @@ public: bool evaluate_media_queries(HTML::Window const&); void for_each_effective_keyframes_at_rule(Function const& callback) const; + void set_rules(Badge, Vector> rules) { m_rules = move(rules); } + Function on_change; private: diff --git a/Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h b/Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h index 77db67db9c..d7ed4424b1 100644 --- a/Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h +++ b/Userland/Libraries/LibWeb/CSS/CSSStyleSheet.h @@ -44,7 +44,6 @@ public: CSSRuleList const& rules() const { return *m_rules; } CSSRuleList& rules() { return *m_rules; } - void set_rules(CSSRuleList& rules) { m_rules = &rules; } CSSRuleList* css_rules() { return m_rules; } CSSRuleList const* css_rules() const { return m_rules; }