RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

LibWeb: Strip and collapse whitespace in document.title

Browse source 
I didn't generalize this into a helper since the HTML spec doesn't
seem to use this particular algorithm for anything else.

This makes the ACID1 test title show up correctly. :^)
This commit is contained in:
Andreas Kling 2020-12-06 21:21:18 +01:00
parent cb04a5c52c
commit d22512a024
1 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Libraries/LibWeb/DOM/Document.cpp
View file

@ -25,6 +25,7 @@
*/ */
#include <AK/StringBuilder.h> #include <AK/StringBuilder.h>
#include <AK/Utf8View.h>
#include <LibCore/Timer.h> #include <LibCore/Timer.h>
#include <LibGUI/Application.h> #include <LibGUI/Application.h>
#include <LibGUI/DisplayLink.h> #include <LibGUI/DisplayLink.h>
@ -61,6 +62,7 @@
#include <LibWeb/Origin.h> #include <LibWeb/Origin.h>
#include <LibWeb/Page/Frame.h> #include <LibWeb/Page/Frame.h>
#include <LibWeb/SVG/TagNames.h> #include <LibWeb/SVG/TagNames.h>
#include <ctype.h>
#include <stdio.h> #include <stdio.h>
namespace Web::DOM { namespace Web::DOM {
@ -240,7 +242,21 @@ String Document::title() const
if (!title_element) if (!title_element)
return {}; return {};
return title_element->text_content(); auto raw_title = title_element->text_content();
StringBuilder builder;
bool last_was_space = false;
for (auto code_point : Utf8View(raw_title)) {
if (isspace(code_point)) {
last_was_space = true;
} else {
if (last_was_space && !builder.is_empty())
builder.append(' ');
builder.append_code_point(code_point);
last_was_space = false;
}
}
return builder.to_string();
} }
void Document::attach_to_frame(Badge<Frame>, Frame& frame) void Document::attach_to_frame(Badge<Frame>, Frame& frame)