RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

LibSoftGPU: Rename window coordinate transformation function

Browse source 
The name `scissor_box_to_window_coordinates` was wildy inaccurate since
we are actually transforming window coordinates into whatever the
coordinate space of the backing bitmap is.
This commit is contained in:
Jelle Raaijmakers 2022-01-08 14:41:25 +01:00 • committed by Linus Groh
parent d54a3f4520
commit d236b0ed12
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibSoftGPU/Device.cpp
View file

@ -81,9 +81,14 @@ static Vector4<f32x4> to_vec4(u32x4 rgba)
}; };
} }
static Gfx::IntRect scissor_box_to_window_coordinates(Gfx::IntRect const& scissor_box, Gfx::IntRect const& window_rect) static Gfx::IntRect window_coordinates_to_target_coordinates(Gfx::IntRect const& window_rect, Gfx::IntRect const& target_rect)
{ {
return scissor_box.translated(0, window_rect.height() - 2 * scissor_box.y() - scissor_box.height()); return {
window_rect.x(),
target_rect.height() - window_rect.height() - window_rect.y(),
window_rect.width(),
window_rect.height(),
};
} }
void Device::setup_blend_factors() void Device::setup_blend_factors()
@ -206,9 +211,8 @@ void Device::rasterize_triangle(const Triangle& triangle)
auto const one_over_area = 1.0f / area; auto const one_over_area = 1.0f / area;
auto render_bounds = m_render_target->rect(); auto render_bounds = m_render_target->rect();
auto window_scissor_rect = scissor_box_to_window_coordinates(m_options.scissor_box, m_render_target->rect());
if (m_options.scissor_enabled) if (m_options.scissor_enabled)
render_bounds.intersect(window_scissor_rect); render_bounds.intersect(window_coordinates_to_target_coordinates(m_options.scissor_box, m_render_target->rect()));
// Obey top-left rule: // Obey top-left rule:
// This sets up "zero" for later pixel coverage tests. // This sets up "zero" for later pixel coverage tests.
@ -845,7 +849,7 @@ void Device::clear_color(const FloatVector4& color)
if (m_options.scissor_enabled) { if (m_options.scissor_enabled) {
auto fill_rect = m_render_target->rect(); auto fill_rect = m_render_target->rect();
fill_rect.intersect(scissor_box_to_window_coordinates(m_options.scissor_box, fill_rect)); fill_rect.intersect(window_coordinates_to_target_coordinates(m_options.scissor_box, fill_rect));
Gfx::Painter painter { *m_render_target }; Gfx::Painter painter { *m_render_target };
painter.fill_rect(fill_rect, fill_color); painter.fill_rect(fill_rect, fill_color);
return; return;
@ -859,7 +863,7 @@ void Device::clear_depth(float depth)
wait_for_all_threads(); wait_for_all_threads();
if (m_options.scissor_enabled) { if (m_options.scissor_enabled) {
m_depth_buffer->clear(scissor_box_to_window_coordinates(m_options.scissor_box, m_render_target->rect()), depth); m_depth_buffer->clear(window_coordinates_to_target_coordinates(m_options.scissor_box, m_render_target->rect()), depth);
return; return;
} }