RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:07:44 +00:00
Code Issues Activity Actions

LibJS: Change all [[RelevantExtensionKeys]] to return constexpr arrays

Browse source 
There's no need to allocate a vector for this internal slot. Similar to
commit: bb11437792
This commit is contained in:
Timothy Flynn 2021-11-29 19:11:49 -05:00 • committed by Linus Groh
parent e27b077c2a
commit d2588d852b
9 changed files with 31 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/Runtime/Intl/Locale.h
View file

@ -6,6 +6,7 @@
#pragma once
#include <AK/Array.h>
#include <AK/Optional.h>
#include <AK/String.h>
#include <AK/Vector.h>
@ -21,7 +22,16 @@ class Locale final : public Object {
public:
static Locale* create(GlobalObject&, Unicode::LocaleID const&);
static Vector<StringView> const& relevant_extension_keys(); // [[RelevantExtensionKeys]]
static constexpr auto relevant_extension_keys()
{
// 14.2.2 Internal slots, https://tc39.es/ecma402/#sec-intl.locale-internal-slots
// The value of the [[RelevantExtensionKeys]] internal slot is « "ca", "co", "hc", "kf", "kn", "nu" ».
// If %Collator%.[[RelevantExtensionKeys]] does not contain "kf", then remove "kf" from %Locale%.[[RelevantExtensionKeys]].
// If %Collator%.[[RelevantExtensionKeys]] does not contain "kn", then remove "kn" from %Locale%.[[RelevantExtensionKeys]].
// FIXME: We do not yet have an Intl.Collator object. For now, we behave as if "kf" and "kn" exist, as test262 depends on it.
return AK::Array { "ca"sv, "co"sv, "hc"sv, "kf"sv, "kn"sv, "nu"sv };
}
Locale(Object& prototype);
Locale(Unicode::LocaleID const&, Object& prototype);